Skip to content

fix(setup): reattach tty before launching chat - #13454

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/rebind-chat-stdin-12074
Closed

fix(setup): reattach tty before launching chat#13454
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/rebind-chat-stdin-12074

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • reattach setup stdin to a real terminal before auto-launching hermes chat
  • fall back to the existing manual instruction when no terminal can be reopened
  • add regression tests for the tty reattach path and the fallback path

Testing

  • pytest -o addopts='' tests/hermes_cli/test_setup.py -k 'offer_launch_chat or reattach_stdin_to_tty'

Closes #12074

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 22, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Closing as stale — the code path this addresses no longer exists on main.

Triage notes (high confidence):
Merged PR #25067 'fix(setup): drop post-setup chat handoff' removed the auto-launch hermes chat code path entirely; the _reattach_stdin_to_tty/_offer_launch_chat functions this PR adds no longer have a caller in main hermes_cli/setup.py.

If this PR's intent is still relevant against the current code, please rebase or open a fresh PR.

(Bulk-closed during a CLI PR triage sweep.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Installing, configuring fully and launching chat yields a crash

3 participants