fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor by djbclark · Pull Request #74452 · NousResearch/hermes-agent

djbclark · 2026-07-29T23:52:10Z

Problem

Python 3.14 removed _initializer / _initargs from ThreadPoolExecutor.__init__, replacing them with _create_worker_context(). The _worker function signature also changed from 4 args to 3. DaemonThreadPoolExecutor._adjust_thread_count() still referenced the old API, causing:

AttributeError: 'DaemonThreadPoolExecutor' object has no attribute '_initializer'

This breaks read_file, search_files, skill_view, and other tools that use the thread pool for dispatch.

Fixes: #69359, #58596

Fix

Version-guarded branch that uses _create_worker_context() on Python 3.14+ (3-arg _worker) and the existing _initializer/_initargs path on Python 3.13- (4-arg _worker).

Why not the approach in #57459?

PR #57459 uses getattr(self, '_initializer', None) which avoids the AttributeError but still passes 4 args to _worker. On Python 3.14, _worker takes only 3 args — so it would fail with TypeError: _worker() takes 3 positional arguments but 4 were given.

Testing

✅ Python 3.14.6: DaemonThreadPoolExecutor.submit(lambda: 42).result() returns 42
✅ Python 3.13.14: same test passes
✅ Live Hermes gateway (Python 3.14): read_file, search_files, skill_view all work after applying this patch

Python 3.14 removed _initializer / _initargs from ThreadPoolExecutor, replacing them with _create_worker_context() and changing _worker() from 4 args to 3. DaemonThreadPoolExecutor._adjust_thread_count() still referenced the old API, causing AttributeError on Python 3.14. Add a version guard that uses the 3.14+ API when available and falls back to the 3.13- API otherwise. Fixes NousResearch#69359, obsoletes NousResearch#57459 (which used getattr fallback that still passes the wrong number of args to 3.14's _worker). Tested: passes on both Python 3.13 and 3.14.

alt-glitch · 2026-07-30T00:02:07Z

This was generated by AI during triage.

Duplicate of #65182: both update tools/daemon_pool.py for Python 3.14's WorkerContext/three-argument _worker contract. #65182 is the earlier open same-mechanism PR; please consolidate there.

teknium1

Thanks for targeting the actual daemon-pool compatibility break. Current main still passes the obsolete four-item tuple at tools/daemon_pool.py:55-60, and this PR's WorkerContext tuple at tools/daemon_pool.py:55-60 addresses that contract change.

Problems

The new Python 3.14-only branch has no repository regression coverage. tests/tools/test_daemon_pool.py:20-75 covers daemon behavior, reuse, and exit behavior, but not the WorkerContext tuple. With requires-python = ">=3.11,<3.14" in pyproject.toml:15, ordinary supported-interpreter runs do not exercise this branch.

Suggested changes

Add a mocked test that captures the threading.Thread invocation and verifies the three-element (executor_ref, WorkerContext, work_queue) tuple and daemon=True for the 3.14 path, while preserving a real submit test for the legacy path.

This is an automated hermes-sweeper review.

teknium1 · 2026-07-30T17:56:53Z

-                name=thread_name,
-                target=_worker,
-                args=(
+            if sys.version_info >= (3, 14):


Please add a regression test for this branch. The current daemon-pool tests do not force a Python 3.14 WorkerContext path, and the project's supported interpreter range remains below 3.14, so normal CI coverage will only exercise the legacy tuple.

sheawinkler · 2026-08-01T16:45:15Z

Independent live verification on Hermes Agent v0.19.0 (2026.7.20) with CPython 3.14.6:

Baseline reproduction against current main/installed tools/daemon_pool.py:
- DaemonThreadPoolExecutor(max_workers=1).submit(lambda: 42) fails at _adjust_thread_count with AttributeError: ... has no attribute _initializer.
Applied this PR's patch verbatim.
Deterministic executor test passed:
- two concurrent results: [9, 16]
- initializer invoked twice with both values preserved
- both workers were daemon threads
- neither worker was registered in concurrent.futures.thread._threads_queues
Fresh-process Hermes integration passed:
- the model emitted exactly two read_file calls in one assistant turn
- both tool results returned successfully
- final output matched both fixtures
- process exited 0

This patch addresses both Python 3.14 changes correctly: _create_worker_context() and the three-argument _worker signature. A getattr(_initializer, None)-only workaround would remain incorrect.

GottZ · 2026-08-03T18:53:21Z

This was generated by AI during triage.

Summary

Eighteen PRs address or reference the shared Python 3.14 DaemonThreadPoolExecutor failure: sixteen visible diffs construct the required three-element WorkerContext tuple, while #59157 and #63777 retain the incompatible four-argument _worker call. #61224 overlaps on the executor repair but also contains distinct gateway-liveness and dotenv-reload changes.

Related pull requests

fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor #57459 fixes — (+38/-13) — n/a: The current diff version-gates the correct WorkerContext tuple and preserves the legacy path, but despite its keep_open review it adds no regression test and duplicates the tested fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 repair.
fix(tools): adapt DaemonThreadPoolExecutor for Python 3.14 _worker signature #58598 [closed] fixes — (+49/-6) — n/a: This closed PR remains relevant as a tested reference that detects _worker arity, supplies _create_worker_context(), and exercises concurrent submission; it is superseded by fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 best fix — (+153/-7) — n/a: The recorded best fix for all five issues uses signature-based WorkerContext dispatch with mocked target-path and conditional legacy-path coverage, and its current diff addresses the keep_open review's Python 3.14 legacy-test concern.
fix(daemon_pool): guard against missing _initializer attr on Python 3.14 #59157 [closed] partial — (+2/-2) — n/a: This closed attempt only defaults the removed attributes while retaining four _worker arguments, so contributor review found that it replaces the reported crash with worker failure or a hung future; it is superseded by fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix(tools): DaemonThreadPoolExecutor Python 3.14 compatibility #59897 [closed] fixes — (+50/-12) — n/a: This closed duplicate remains relevant as a valid capability-detected WorkerContext implementation with initializer coverage, but it is superseded by fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix(daemon): support Python 3.14 multiprocessing pools #60061 fixes — (+18/-5) — n/a: The capability-based branch constructs the correct WorkerContext tuple, but despite its keep_open review it adds no executable branch test and duplicates fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699's tested cause coverage.
fix: Python 3.14 compatibility (daemon_pool worker signature, gateway liveness argv, dotenv reload race) #61224 fixes — (+345/-12) — n/a: Its tested daemon-pool helper covers both worker layouts, while its gateway-liveness and dotenv-retry changes are distinct salvageable work consistent with the keep_open review.
fix(daemon_pool): handle missing initializer in _adjust_thread_count #63777 [closed] partial — (+2/-2) — n/a: This closed duplicate remains relevant as the same incomplete fallback as fix(daemon_pool): guard against missing _initializer attr on Python 3.14 #59157, retaining the obsolete four-argument worker call and therefore being superseded by fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix(daemon_pool): support Python 3.14 ThreadPoolExecutor WorkerContext signature #63780 [closed] fixes — (+142/-7) — n/a: This closed duplicate remains a detailed reference because signature-based dispatch supplies WorkerContext and its tests cover submission, initializer behavior, daemon semantics, and reuse; it is superseded by fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182 best fix — (+21/-8) — n/a: This recorded best fix for [Bug]: DaemonThreadPoolExecutor crashes on Python 3.14 — AttributeError: "_initializer" #69359 capability-detects _create_worker_context() and builds the correct tuple; its maintainer-bot keep_open verdict identifies the salvage path as adding the mocked tuple-and-daemon=True regression already demonstrated elsewhere in the complex.
fix: support DaemonThreadPoolExecutor on Python 3.14 #69108 fixes — (+18/-7) — n/a: The capability-based repair is correct, but despite its maintainer-bot keep_open verdict it lacks the requested mocked test and duplicates the earlier fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182 and better-tested fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 implementations.
fix(tools): support CPython 3.14 ThreadPoolExecutor internals in DaemonThreadPoolExecutor #69209 fixes — (+23/-6) — n/a: Its prepare_context probe selects the correct WorkerContext tuple, but despite its keep_open review it adds no regression coverage and duplicates fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 at the same spawn site.
fix: DaemonThreadPoolExecutor compat with Python 3.14 #69311 fixes — (+46/-12) — n/a: The WorkerContext tuple addresses the cause, but despite its keep_open review the diff uses a version gate, adds unrelated initializer backfills, and omits the requested mocked test, making it a weaker duplicate of fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix(tools): spawn daemon workers with the 3.14 worker context #72955 [closed] fixes — (+32/-7) — n/a: This closed-in-favor-of-fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182 duplicate remains relevant for its capability-based worker-argument helper, stdlib-signature conformance test, and measured evidence that the four-argument fallback can hang.
fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor #74452 fixes — (+17/-6) — n/a: The version-gated WorkerContext branch has independent Python 3.14 executor and Hermes integration evidence, but despite its keep_open review the visible diff lacks repository regression coverage and duplicates fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
fix: Python 3.14 compat in DaemonThreadPoolExecutor #76212 [closed] fixes — (+15/-5) — n/a: This closed PR remains relevant as a successful minimal WorkerContext reference, but it is superseded by fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 after its author switched to the supported interpreter.
fix(tools): support Python 3.14 worker context in DaemonThreadPoolExecutor (#76621) #76756 [closed] fixes — (+57/-11) — n/a: Although closed despite its maintainer-bot keep_open verdict, it should remain closed as a duplicate because its capability repair and mocked tuple-and-daemon=True test are already represented by fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 rather than requiring a reopen.
fix(tools): support Python 3.14 ThreadPoolExecutor internals in DaemonThreadPoolExecutor #76817 fixes — (+20/-6) — n/a: The capability-based repair has live Python 3.14 verification, but despite its keep_open review it lacks the requested mocked branch test and duplicates fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.

Duplicates

#57459, #58598, #58699, #59897, #60061, #63780, #65182, #69108, #69209, #69311, #72955, #74452, #76212, #76756, and #76817 substantially implement the same WorkerContext-aware spawn repair; #59157 and #63777 duplicate the incomplete four-argument fallback. #61224 overlaps only in its daemon-pool portion because its gateway and env-loader changes are distinct.

Suggested consolidation

Author action: rebase #58699 onto main, or split out the part that can merge, preserving its recorded best-fix implementation and mocked cross-version coverage; keep recorded best fix #65182 open with the salvage path of adopting the focused mocked tuple test and reconciling it with #58699. Despite the keep_open reviews or verdicts on #57459, #60061, #69108, #69209, #69311, #74452, and #76817, their visible diffs provide no stronger cause coverage than #58699/#65182, so close them as explicit duplicates, keep the already-closed PRs closed, and request author action on #61224 to split its distinct gateway-liveness and dotenv-retry work from the duplicate daemon-pool repair.

Complex graph

flowchart TD
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I58596(["issue #58596 (open)"])
    I59896(["issue #59896 (open)"])
    I63769(["issue #63769 (open)"])
    I69359(["issue #69359 (open)"])
    I76621(["issue #76621 (open)"])
    subgraph Dup57459 ["PRs duplicating each other"]
        P57459["PR #57459 (open)"]
        P58598["PR #58598 (closed)"]
        P58699["PR #58699 (open)"]
        P59157["PR #59157 (closed)"]
        P59897["PR #59897 (closed)"]
        P60061["PR #60061 (open)"]
        P61224["PR #61224 (open)"]
        P63777["PR #63777 (closed)"]
        P63780["PR #63780 (closed)"]
        P65182["PR #65182 (open)"]
        P69108["PR #69108 (open)"]
        P69209["PR #69209 (open)"]
        P69311["PR #69311 (open)"]
        P72955["PR #72955 (closed)"]
        P74452["PR #74452 (open)"]
        P76212["PR #76212 (closed)"]
        P76756["PR #76756 (closed)"]
        P76817["PR #76817 (open)"]
    end
    P74452 -.->|partial| I58596
    P74452 -.->|partial| I59896
    P74452 -->|fixes| I63769
    P74452 -.->|partial| I69359
    P74452 -->|fixes| I76621
    class I58596 open
    class I59896 open
    class I63769 open
    class I69359 open
    class I76621 open
    class P57459 open
    class P58598 closed
    class P58699 open
    class P59157 closed
    class P59897 closed
    class P60061 open
    class P61224 open
    class P63777 closed
    class P63780 closed
    class P65182 open
    class P69108 open
    class P69209 open
    class P69311 open
    class P72955 closed
    class P74452 open
    class P76212 closed
    class P76756 closed
    class P76817 open
    class P58699 best
    class P58699 best
    class P58699 best
    class P58699 best
    class P58699 best
    class P65182 best
    class P74452 target
    click I58596 "https://github.com/NousResearch/hermes-agent/issues/58596"
    click I59896 "https://github.com/NousResearch/hermes-agent/issues/59896"
    click I63769 "https://github.com/NousResearch/hermes-agent/issues/63769"
    click I69359 "https://github.com/NousResearch/hermes-agent/issues/69359"
    click I76621 "https://github.com/NousResearch/hermes-agent/issues/76621"
    click P57459 "https://github.com/NousResearch/hermes-agent/pull/57459"
    click P58598 "https://github.com/NousResearch/hermes-agent/pull/58598"
    click P58699 "https://github.com/NousResearch/hermes-agent/pull/58699"
    click P59157 "https://github.com/NousResearch/hermes-agent/pull/59157"
    click P59897 "https://github.com/NousResearch/hermes-agent/pull/59897"
    click P60061 "https://github.com/NousResearch/hermes-agent/pull/60061"
    click P61224 "https://github.com/NousResearch/hermes-agent/pull/61224"
    click P63777 "https://github.com/NousResearch/hermes-agent/pull/63777"
    click P63780 "https://github.com/NousResearch/hermes-agent/pull/63780"
    click P65182 "https://github.com/NousResearch/hermes-agent/pull/65182"
    click P69108 "https://github.com/NousResearch/hermes-agent/pull/69108"
    click P69209 "https://github.com/NousResearch/hermes-agent/pull/69209"
    click P69311 "https://github.com/NousResearch/hermes-agent/pull/69311"
    click P72955 "https://github.com/NousResearch/hermes-agent/pull/72955"
    click P74452 "https://github.com/NousResearch/hermes-agent/pull/74452"
    click P76212 "https://github.com/NousResearch/hermes-agent/pull/76212"
    click P76756 "https://github.com/NousResearch/hermes-agent/pull/76756"
    click P76817 "https://github.com/NousResearch/hermes-agent/pull/76817"

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 18 pull requests and 5 issues in this complex. Each diff was read against this issue; Assessment working set: 70 kB of PR diffs, 52 kB of issue/PR text, 40 kB of discussion (59 comments), 115 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

djbclark · 2026-08-08T00:03:26Z

Migrated to the authoritative fork: djbclark#3. Closing this upstream copy per operator direction; no further work should be coordinated here.

djbclark · 2026-08-08T00:03:27Z

Migrated to the authoritative fork: djbclark#3. Closing this upstream copy per operator direction.

alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/tools Tool registry, model_tools, toolsets duplicate This issue or pull request already exists needs-decision Awaiting maintainer decision before any implementation labels Jul 30, 2026

teknium1 reviewed Jul 30, 2026

View reviewed changes

alt-glitch removed needs-decision Awaiting maintainer decision before any implementation sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages labels Aug 4, 2026

djbclark mentioned this pull request Aug 8, 2026

fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor djbclark/hermes-agent#3

Open

djbclark closed this Aug 8, 2026

spfcraze mentioned this pull request Aug 10, 2026

ci: add Python 3.14 test lane exercising the 3.14 compatibility surface spfcraze/hermes-agent#54

Closed

Navigation Menu

Uh oh!

fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor - #74452

fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor#74452
djbclark wants to merge 1 commit into
NousResearch:mainfrom
djbclark:fix/python-314-daemon-pool

djbclark commented Jul 29, 2026

Uh oh!

alt-glitch commented Jul 30, 2026

Uh oh!

teknium1 left a comment

Uh oh!

teknium1 Jul 30, 2026

Uh oh!

sheawinkler commented Aug 1, 2026

Uh oh!

GottZ commented Aug 3, 2026

Uh oh!

djbclark commented Aug 8, 2026

Uh oh!

djbclark commented Aug 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

djbclark commented Jul 29, 2026

Problem

Fix

Why not the approach in #57459?

Testing

Uh oh!

alt-glitch commented Jul 30, 2026

Uh oh!

teknium1 left a comment

Choose a reason for hiding this comment

Problems

Suggested changes

Uh oh!

teknium1 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

sheawinkler commented Aug 1, 2026

Uh oh!

GottZ commented Aug 3, 2026

Summary

Related pull requests

Duplicates

Suggested consolidation

Complex graph

Uh oh!

djbclark commented Aug 8, 2026

Uh oh!

djbclark commented Aug 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants