fix(tools): support CPython 3.14 ThreadPoolExecutor internals in DaemonThreadPoolExecutor

[Soju06]

Problem

DaemonThreadPoolExecutor._adjust_thread_count mirrors CPython 3.8–3.13 ThreadPoolExecutor internals (self._initializer / self._initargs and the 5-arg _worker signature). CPython 3.14 moved per-worker state into a WorkerContext built by the new prepare_context() classmethod and changed _worker to (executor_ref, ctx, work_queue).

Under Python 3.14 every submit() dies on first dispatch:

AttributeError: 'DaemonThreadPoolExecutor' object has no attribute '_initializer'

This breaks all concurrent tool batches and background memory sync. Reproduces on pure main: tests/tools/test_daemon_pool.py, tests/agent/test_memory_async_sync.py, and the TestSegmentedDispatchIntegration cluster all fail under a 3.14 interpreter.

Fix

Branch on hasattr(ThreadPoolExecutor, "prepare_context") and pass the matching worker args on each interpreter family, keeping daemon=True and the deliberately-skipped _threads_queues registration on both.

Testing

• Python 3.14.6: tests/tools/test_daemon_pool.py, tests/agent/test_memory_async_sync.py, tests/run_agent/test_tool_batch_segmentation.py — 38 passed, 1 skipped (all failed before on 3.14).
• The 3.8–3.13 path is untouched (same attributes/signature as before, now behind the feature check).

🤖 Generated with Claude Code

[alt-glitch]

This was generated by AI during triage.

Duplicate of #65182: both live diffs implement the same CPython 3.14 WorkerContext and worker-argument compatibility repair in tools/daemon_pool.py.

[teknium1]

Thanks for targeting the actual CPython 3.14 contract change. Current main still passes the legacy tuple through tools/daemon_pool.py:55-60, while CPython 3.14 invokes _worker with (executor_ref, self._create_worker_context(), work_queue) (Lib/concurrent/futures/thread.py:97, 185-187, 233-236). The new branch is therefore the correct repair direction.

Problems

• The diff adds no regression coverage. The supported interpreter range remains <3.14 in pyproject.toml:15, and tests/tools/test_daemon_pool.py:20-83 does not exercise or mock the WorkerContext branch.
• The member triage comment on this PR links open #65182 as the same WorkerContext repair; its live diff implements the same three-argument adaptation.

Suggested changes

• Add a mocked threading.Thread construction test that verifies the WorkerContext tuple and daemon=True without needing CPython 3.14 in CI.
• Coordinate consolidation with #65182 so the selected repair carries regression coverage.

Automated hermes-sweeper review.

[teknium1]

Please add a mocked regression test for this branch. CI currently supports Python <3.14, so the normal daemon-pool submission tests cannot execute this WorkerContext tuple.

[GottZ]

This was generated by AI during triage.

Summary

Eighteen PRs address or reference the shared Python 3.14 DaemonThreadPoolExecutor failure: sixteen visible diffs construct the required three-element WorkerContext tuple with differing detection and test coverage, while #59157 and #63777 retain the incompatible four-argument call. #61224 additionally contains distinct gateway-liveness and dotenv-reload fixes.

Related pull requests

• fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor #57459 fixes — (+38/-13) — n/a: The visible diff now version-gates the correct WorkerContext tuple and preserves the legacy path, but adds no regression test and overlaps the tested fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 repair.
• fix(tools): adapt DaemonThreadPoolExecutor for Python 3.14 _worker signature #58598 [closed] fixes — (+49/-6) — n/a: Closed as a duplicate but still relevant as a tested reference, it detects _worker arity, supplies _create_worker_context(), and exercises concurrent submission.
• fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699 best fix — (+153/-7) — n/a: The recorded best fix for all five issues uses signature-based dispatch with extensive cross-version and mocked WorkerContext coverage; its visible skipif addresses the keep_open review's legacy-test concern.
• fix(daemon_pool): guard against missing _initializer attr on Python 3.14 #59157 [closed] partial — (+2/-2) — n/a: Closed after contributor review found that defaulting the removed attributes retains four _worker arguments, replacing the initial crash with worker failure or a hung future.
• fix(tools): DaemonThreadPoolExecutor Python 3.14 compatibility #59897 [closed] fixes — (+50/-12) — n/a: Closed as a duplicate but still relevant as a valid capability-detected WorkerContext implementation with an initializer regression test.
• fix(daemon): support Python 3.14 multiprocessing pools #60061 fixes — (+18/-5) — n/a: The capability-based branch constructs the correct tuple, but despite its keep_open review it adds no executable branch test and duplicates fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699's tested cause coverage.
• fix: Python 3.14 compatibility (daemon_pool worker signature, gateway liveness argv, dotenv reload race) #61224 fixes — (+345/-12) — n/a: Its daemon-pool helper and tests cover both worker layouts, while the same diff also carries distinct gateway-liveness and dotenv-retry repairs that require separate salvage.
• fix(daemon_pool): handle missing initializer in _adjust_thread_count #63777 [closed] partial — (+2/-2) — n/a: Closed as a duplicate of fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor #57459, it remains relevant as the same incomplete attribute-default approach as fix(daemon_pool): guard against missing _initializer attr on Python 3.14 #59157, retaining the obsolete four-argument worker call.
• fix(daemon_pool): support Python 3.14 ThreadPoolExecutor WorkerContext signature #63780 [closed] fixes — (+142/-7) — n/a: Closed as a duplicate but still relevant as a detailed signature-detected WorkerContext reference with submit, initializer, daemon, and reuse coverage.
• fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182 best fix — (+21/-8) — n/a: This recorded best fix for [Bug]: DaemonThreadPoolExecutor crashes on Python 3.14 — AttributeError: "_initializer" #69359 capability-detects _create_worker_context() and builds the correct tuple; its maintainer-bot keep_open verdict requests mocked branch coverage absent from the visible diff.
• fix: support DaemonThreadPoolExecutor on Python 3.14 #69108 fixes — (+18/-7) — n/a: The capability-based repair is correct, but despite its maintainer-bot keep_open verdict it lacks the requested mocked test and duplicates the earlier fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182 implementation.
• fix(tools): support CPython 3.14 ThreadPoolExecutor internals in DaemonThreadPoolExecutor #69209 fixes — (+23/-6) — n/a: The target PR selects the correct WorkerContext tuple through prepare_context, but despite its keep_open review it adds no mocked regression and its visible production repair duplicates fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182.
• fix: DaemonThreadPoolExecutor compat with Python 3.14 #69311 fixes — (+46/-12) — n/a: The WorkerContext tuple fixes the cause, but despite its keep_open review the diff uses a version gate, adds unsupported initializer backfills, and omits the requested mocked test.
• fix(tools): spawn daemon workers with the 3.14 worker context #72955 [closed] fixes — (+32/-7) — n/a: Closed in favor of fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182, it remains relevant for its capability-based helper, live-signature conformance test, and measured evidence that the four-argument fallback can hang.
• fix(tools): Python 3.14 compatibility for DaemonThreadPoolExecutor #74452 fixes — (+17/-6) — n/a: The version-gated repair has independent Python 3.14 executor and Hermes integration evidence, but despite its keep_open review it lacks repository regression coverage and duplicates fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.
• fix: Python 3.14 compat in DaemonThreadPoolExecutor #76212 [closed] fixes — (+15/-5) — n/a: Closed after the author moved to the supported interpreter, it remains relevant as a successful but untested version-gated WorkerContext implementation.
• fix(tools): support Python 3.14 worker context in DaemonThreadPoolExecutor (#76621) #76756 [closed] fixes — (+57/-11) — n/a: Closed as a duplicate despite its maintainer-bot keep_open verdict, it remains a useful reference because its capability branch and mocked test verify the exact tuple and daemon=True; reopening is not recommended.
• fix(tools): support Python 3.14 ThreadPoolExecutor internals in DaemonThreadPoolExecutor #76817 fixes — (+20/-6) — n/a: The capability-based repair has live Python 3.14 verification, but despite its keep_open review it lacks the requested mocked test and duplicates fix(daemon_pool): support CPython 3.14 ThreadPoolExecutor internals #65182/fix(daemon-pool): support Python 3.14 _worker signature change (#58596) #58699.

Duplicates

#57459, #58598, #58699, #59897, #60061, #63780, #65182, #69108, #69209, #69311, #72955, #74452, #76212, #76756, and #76817 substantially implement the same WorkerContext-aware spawn repair; #59157 and #63777 are duplicate incomplete four-argument fallbacks. #61224 overlaps only in its daemon-pool portion because its gateway and env-loader changes are distinct.

Suggested consolidation

Author action: rebase #58699 onto main, or split out the part that can merge, preserving its recorded best-fix implementation and mocked target-path coverage; keep recorded best fix #65182 open with the salvage path of adopting the focused mocked test and reconciling its implementation with #58699. Despite the keep_open reviews or verdicts on #57459, #60061, #69108, #69209, #69311, #74452, and #76817, their visible diffs add no stronger cause coverage than #58699/#65182, so close them as explicit duplicates; keep the already-closed PRs closed, and keep #61224 open only with a salvage path that splits its distinct gateway-liveness and dotenv-retry work from the duplicate daemon-pool repair.

Complex graph

flowchart TD
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I58596(["issue #58596 (open)"])
    I59896(["issue #59896 (open)"])
    I63769(["issue #63769 (open)"])
    I69359(["issue #69359 (open)"])
    I76621(["issue #76621 (open)"])
    subgraph Dup57459 ["PRs duplicating each other"]
        P57459["PR #57459 (open)"]
        P58598["PR #58598 (closed)"]
        P58699["PR #58699 (open)"]
        P59157["PR #59157 (closed)"]
        P59897["PR #59897 (closed)"]
        P60061["PR #60061 (open)"]
        P61224["PR #61224 (open)"]
        P63777["PR #63777 (closed)"]
        P63780["PR #63780 (closed)"]
        P65182["PR #65182 (open)"]
        P69108["PR #69108 (open)"]
        P69209["PR #69209 (open)"]
        P69311["PR #69311 (open)"]
        P72955["PR #72955 (closed)"]
        P74452["PR #74452 (open)"]
        P76212["PR #76212 (closed)"]
        P76756["PR #76756 (closed)"]
        P76817["PR #76817 (open)"]
    end
    P69209 -->|fixes| I58596
    P69209 -->|fixes| I59896
    P69209 -->|fixes| I63769
    P69209 -->|fixes| I69359
    P69209 -->|fixes| I76621
    class I58596 open
    class I59896 open
    class I63769 open
    class I69359 open
    class I76621 open
    class P57459 open
    class P58598 closed
    class P58699 open
    class P59157 closed
    class P59897 closed
    class P60061 open
    class P61224 open
    class P63777 closed
    class P63780 closed
    class P65182 open
    class P69108 open
    class P69209 open
    class P69311 open
    class P72955 closed
    class P74452 open
    class P76212 closed
    class P76756 closed
    class P76817 open
    class P58699 best
    class P58699 best
    class P58699 best
    class P58699 best
    class P58699 best
    class P65182 best
    class P69209 target
    click I58596 "https://github.com/NousResearch/hermes-agent/issues/58596"
    click I59896 "https://github.com/NousResearch/hermes-agent/issues/59896"
    click I63769 "https://github.com/NousResearch/hermes-agent/issues/63769"
    click I69359 "https://github.com/NousResearch/hermes-agent/issues/69359"
    click I76621 "https://github.com/NousResearch/hermes-agent/issues/76621"
    click P57459 "https://github.com/NousResearch/hermes-agent/pull/57459"
    click P58598 "https://github.com/NousResearch/hermes-agent/pull/58598"
    click P58699 "https://github.com/NousResearch/hermes-agent/pull/58699"
    click P59157 "https://github.com/NousResearch/hermes-agent/pull/59157"
    click P59897 "https://github.com/NousResearch/hermes-agent/pull/59897"
    click P60061 "https://github.com/NousResearch/hermes-agent/pull/60061"
    click P61224 "https://github.com/NousResearch/hermes-agent/pull/61224"
    click P63777 "https://github.com/NousResearch/hermes-agent/pull/63777"
    click P63780 "https://github.com/NousResearch/hermes-agent/pull/63780"
    click P65182 "https://github.com/NousResearch/hermes-agent/pull/65182"
    click P69108 "https://github.com/NousResearch/hermes-agent/pull/69108"
    click P69209 "https://github.com/NousResearch/hermes-agent/pull/69209"
    click P69311 "https://github.com/NousResearch/hermes-agent/pull/69311"
    click P72955 "https://github.com/NousResearch/hermes-agent/pull/72955"
    click P74452 "https://github.com/NousResearch/hermes-agent/pull/74452"
    click P76212 "https://github.com/NousResearch/hermes-agent/pull/76212"
    click P76756 "https://github.com/NousResearch/hermes-agent/pull/76756"
    click P76817 "https://github.com/NousResearch/hermes-agent/pull/76817"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 18 pull requests and 5 issues in this complex. Each diff was read against this issue; Assessment working set: 70 kB of PR diffs, 52 kB of issue/PR text, 40 kB of discussion (59 comments), 115 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.