fix: aux-slot endpoint persistence, empty-response failure_reason, #72285 docs (sibling wave) - #73769
Merged
Merged
Conversation
alt-glitch
added
type/bug
Contributor
૮ >ﻌ< ა ci reviewran on de189ec all good! |
Sibling of #65254 (main-slot endpoint preservation): the auxiliary scope of POST /api/model/set dropped the request's base_url/api_key on the floor, so an aux slot pinned to a custom/local endpoint silently depended on model.base_url — and broke the moment the main slot switched away and cleared it. The aux resolver already reads auxiliary.<task>.base_url/api_key (_resolve_task_provider_model); this persists them. Desktop side: setAuxiliaryToMain / applyAuxiliaryDraft now carry the user-defined provider's api_url as base_url, mirroring applyMainModel.
…n path Sibling of #64686: _run_agent's empty-final_response early return dropped failure_reason (and #64686 only fixed the non-empty path), so downstream consumers (TUI billing surface, transient-failure persistence) lost the structured reason exactly when a failed run produced no text. Also hardens the two BasePlatformAdapter identity checks (edit_message / delete_message) with getattr so duck-typed adapters without the attribute mean 'capability absent', not AttributeError — this was crashing the send_progress_messages path for minimal adapters and test fakes.
The multiplexed listener now rejects the default API_SERVER_KEY on /p/<profile>/ prefixes (fail-closed per-profile keys). Add the multi-profile routing section with an explicit breaking-change callout for the next release notes.
teknium1
force-pushed
the
hermes/hermes-c643316b
branch
from
July 29, 2026 04:29
668d56c to
de189ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three sibling follow-ups from this week's merges: auxiliary model assignments now persist their endpoint (sibling of #65254), the gateway's empty-response return path now forwards
failure_reason(sibling of #64686), and the #72285 profile-bound HTTP auth breaking change is documented for the next release notes.Changes
hermes_cli/web_server.py: the auxiliary scope ofPOST /api/model/setpersistsbase_url/api_keyintoauxiliary.<task>.*(previously dropped — the aux resolver at_resolve_task_provider_modelalready reads them). Stale-endpoint scrub on provider switch preserved.ModelAssignmentdocstrings updated.apps/desktop/.../model-settings.tsx:setAuxiliaryToMain/applyAuxiliaryDraftcarry the user-defined provider'sapi_urlasbase_url, mirroringapplyMainModel(fix(desktop): preserve local model provider endpoint #65254).gateway/run.py: the empty-final_responseearly return in_run_agentforwardsfailure_reason(fix(gateway): preserve rate-limit failure metadata #64686 fixed only the non-empty path). Also hardened bothBasePlatformAdapteridentity checks (edit_message,delete_message) withgetattrso duck-typed adapters without the attribute mean "capability absent," notAttributeError.website/docs/user-guide/features/api-server.md: new "Multi-profile routing" section with an explicit breaking-change callout — defaultAPI_SERVER_KEYis now rejected on/p/<profile>/prefixes (fix(gateway): bind HTTP auth to routed profiles #72285).Validation
tests/gateway/test_compression_failure_session_sync.py+test_42039_duplicate_user_message.pytests/hermes_cli/test_web_server.py -k set_modelapps/desktopvitestmodel-settings.test.tsxnpx tsc --noEmit(touched files)docusaurus buildInfographic