fix(desktop): preserve local model provider endpoint - #65254
Merged
Conversation
Contributor
|
Thanks for the focused regression fix. Current main still posts the settings selection without The added Ollama regression assertion covers the reported settings-path failure. Automated hermes-sweeper review. |
teknium1
force-pushed
the
fix-desktop-ollama-base-url
branch
from
July 28, 2026 21:00
083a55f to
fe4c92f
Compare
teknium1
added a commit
that referenced
this pull request
Jul 29, 2026
Sibling of #65254 (main-slot endpoint preservation): the auxiliary scope of POST /api/model/set dropped the request's base_url/api_key on the floor, so an aux slot pinned to a custom/local endpoint silently depended on model.base_url — and broke the moment the main slot switched away and cleared it. The aux resolver already reads auxiliary.<task>.base_url/api_key (_resolve_task_provider_model); this persists them. Desktop side: setAuxiliaryToMain / applyAuxiliaryDraft now carry the user-defined provider's api_url as base_url, mirroring applyMainModel.
teknium1
added a commit
that referenced
this pull request
Jul 29, 2026
Sibling of #65254 (main-slot endpoint preservation): the auxiliary scope of POST /api/model/set dropped the request's base_url/api_key on the floor, so an aux slot pinned to a custom/local endpoint silently depended on model.base_url — and broke the moment the main slot switched away and cleared it. The aux resolver already reads auxiliary.<task>.base_url/api_key (_resolve_task_provider_model); this persists them. Desktop side: setAuxiliaryToMain / applyAuxiliaryDraft now carry the user-defined provider's api_url as base_url, mirroring applyMainModel.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
Sibling of NousResearch#65254 (main-slot endpoint preservation): the auxiliary scope of POST /api/model/set dropped the request's base_url/api_key on the floor, so an aux slot pinned to a custom/local endpoint silently depended on model.base_url — and broke the moment the main slot switched away and cleared it. The aux resolver already reads auxiliary.<task>.base_url/api_key (_resolve_task_provider_model); this persists them. Desktop side: setAuxiliaryToMain / applyAuxiliaryDraft now carry the user-defined provider's api_url as base_url, mirroring applyMainModel.
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
Sibling of NousResearch#65254 (main-slot endpoint preservation): the auxiliary scope of POST /api/model/set dropped the request's base_url/api_key on the floor, so an aux slot pinned to a custom/local endpoint silently depended on model.base_url — and broke the moment the main slot switched away and cleared it. The aux resolver already reads auxiliary.<task>.base_url/api_key (_resolve_task_provider_model); this persists them. Desktop side: setAuxiliaryToMain / applyAuxiliaryDraft now carry the user-defined provider's api_url as base_url, mirroring applyMainModel.
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
Sibling of NousResearch#65254 (main-slot endpoint preservation): the auxiliary scope of POST /api/model/set dropped the request's base_url/api_key on the floor, so an aux slot pinned to a custom/local endpoint silently depended on model.base_url — and broke the moment the main slot switched away and cleared it. The aux resolver already reads auxiliary.<task>.base_url/api_key (_resolve_task_provider_model); this persists them. Desktop side: setAuxiliaryToMain / applyAuxiliaryDraft now carry the user-defined provider's api_url as base_url, mirroring applyMainModel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65201
Summary
Preserves the configured endpoint when selecting a local or user-defined model provider in the Desktop model settings.
Previously, Desktop displayed the selected Ollama provider and model correctly, but the model assignment request omitted the provider endpoint. The backend then cleared the previous
base_url, leaving the local provider without an endpoint and allowing runtime resolution to fall back to OpenRouter-compatible handling.Root cause
/api/model/optionsexposes the endpoint for user-defined providers asapi_url.The Desktop
ModelOptionProvidertype did not include that field, andapplyMainModel()only submitted:modelproviderscopeAs a result, switching to Ollama/custom persisted the provider selection without persisting its endpoint.
Fix
api_urltoModelOptionProvider.api_urlback asbase_urlwhen applying the main model.Testing
preserves a user-defined provider endpoint when applying the main modelreact-hooks/exhaustive-depswarning remains outside this change.git diff --check: passedorigin/mainand reran the focused tests successfully.Typecheck note
The full Desktop typecheck is currently blocked by 7 unrelated errors in existing assistant-ui integration files involving installed package API mismatches. None of the reported errors are in the files changed by this PR.