docs(feishu): update stale feishu_comment path references after module migration - #73090
Conversation
9156721 to
fb0e1b5
Compare
5f3a76f to
4f56009
Compare
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Seven PRs address the same post-migration Feishu path drift: #71185, #71190, #71273, #71371, and #71551 correct one or both tools-reference locales; #71501 corrects the runnable CLI examples and usage string; and #73090 consolidates those changes while also updating the adapter docstring.
Related pull requests
- #71185 [closed]
related— (+1/-1) — superseded scope: Corrects the English tools reference from the removedgateway/platforms/feishu_comment.pypath toplugins/platforms/feishu/feishu_comment.py; although closed after restructuring concerns, its exact change is retained in #73090. - #71190 [closed]
related— (+1/-1) — superseded scope: Applies the same stale-path correction to the zh-Hans tools-reference mirror; although closed after restructuring concerns, its exact change is retained in #73090. - #71273 [closed]
duplicate— (+2/-2) — superseded combined scope: Corrects the stalefeishu_comment.pypath in both English and zh-Hans tools-reference files, combining the changes separately proposed by #71185 and #71190; it remains relevant as a closed predecessor now subsumed by #73090. - #71371 [closed]
duplicate— (+1/-1) — duplicate of #71185 and superseded by #73090: Corrects the English tools-reference path to the migrated Feishu handler location; it was closed in favor of the consolidated replacement. - #71501 [closed]
duplicate— (+11/-11) — superseded functional-documentation scope: Replaces the obsoletegateway.platforms.feishu_comment_rulesmodule invocation in the usage string and both locale guides, directly fixing the documented commands that would target the pre-migration module; it was closed because #73090 includes these changes. - #71551 [closed]
duplicate— (+1/-1) — duplicate of #71190 and superseded by #73090: Corrects the zh-Hans tools-reference path to the migrated handler location; it was closed in favor of the consolidated replacement. - #73090
related— (+14/-14) — consolidated scope, with no recorded Verify best-fix verdict: Updates all six identified documentation and inline-code references, covering both tools-reference locales, both CLI-guide locales, the rules usage string, and the adapter docstring against the same module-migration cause.
Duplicates
#71185 and #71371 contain the same English tools-reference correction; #71190 and #71551 contain the same zh-Hans correction; #71273 combines those two changes. #71501 is the CLI/usage subset of #73090, while #73090 also subsumes all tools-reference changes from #71185, #71190, #71273, #71371, and #71551.
Suggested consolidation
Keep #73090 open with a salvage path: retain its six-file consolidated correction because the diff covers the tools-reference paths, runnable CLI examples, module usage string, and adapter cross-reference in one place. There is no recorded Verify best-fix verdict, so this is not a merge recommendation; #71185, #71190, #71273, #71371, #71501, and #71551 can remain closed as duplicates or superseded subsets of #73090.
Complex graph
flowchart TD
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
subgraph Dup71185 ["PRs duplicating each other"]
P71185["PR #71185 (closed)"]
P71190["PR #71190 (closed)"]
P71273["PR #71273 (closed)"]
P71371["PR #71371 (closed)"]
P71501["PR #71501 (closed)"]
P71551["PR #71551 (closed)"]
P73090["PR #73090 (open)"]
end
class P71185 closed
class P71190 closed
class P71273 closed
class P71371 closed
class P71501 closed
class P71551 closed
class P73090 open
class P73090 target
click P71185 "https://github.com/NousResearch/hermes-agent/pull/71185"
click P71190 "https://github.com/NousResearch/hermes-agent/pull/71190"
click P71273 "https://github.com/NousResearch/hermes-agent/pull/71273"
click P71371 "https://github.com/NousResearch/hermes-agent/pull/71371"
click P71501 "https://github.com/NousResearch/hermes-agent/pull/71501"
click P71551 "https://github.com/NousResearch/hermes-agent/pull/71551"
click P73090 "https://github.com/NousResearch/hermes-agent/pull/73090"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).
Cross-PR triage: Reviewed 7 pull requests and 0 issues in this complex. Diffs were read for 6 of 7 PRs (rest unavailable); Assessment working set: 8 kB of PR diffs, 10 kB of issue/PR text, 2 kB of discussion (6 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
f713c18 to
c4c49da
Compare
…e migration - Problem: docs and code references still point to gateway/platforms/feishu_comment.py and gateway.platforms.feishu_comment_rules, but the modules moved to plugins/platforms/feishu/ long ago. - Fix: update all stale path references in tools-reference (EN + zh-Hans), feishu messaging guide (EN + zh-Hans), feishu_comment_rules.py usage string, and adapter.py docstring. - Verification: grep confirms zero remaining old-path references in the changed files; new paths match the actual file locations on disk. Co-Authored-By: Paperclip <noreply@paperclip.ing>
c4c49da to
c3c5717
Compare
Problem
Six files still reference the old module locations for the Feishu document-comment handler:
gateway/platforms/feishu_comment.pyandgateway.platforms.feishu_comment_rulesplugins/platforms/feishu/long agoThis misleads users trying to run
python -m gateway.platforms.feishu_comment_rules status(ModuleNotFoundError) and anyone looking for the source file at the documented path.Triage / Root cause
The feishu platform modules moved from
gateway/platforms/toplugins/platforms/feishu/but docs and inline usage strings were not updated to match.Affected files:
website/docs/reference/tools-reference.md— EN path referencewebsite/i18n/zh-Hans/.../reference/tools-reference.md— zh-Hans mirrorwebsite/docs/user-guide/messaging/feishu.md— CLI exampleswebsite/i18n/zh-Hans/.../messaging/feishu.md— zh-Hans mirrorplugins/platforms/feishu/feishu_comment_rules.py— usage stringplugins/platforms/feishu/adapter.py— docstring cross-referenceFix
gateway/platforms/feishu_comment→plugins/platforms/feishu/feishu_commentgateway.platforms.feishu_comment_rules→plugins.platforms.feishu.feishu_comment_rulesConsolidates and replaces #71371, #71501, and #71551 (closed after rebase became impossible from stale branches).
Verification
grep -r "gateway/platforms/feishu_comment\|gateway.platforms.feishu_comment" website/ plugins/platforms/feishu/returns zero matches in the changed filesls plugins/platforms/feishu/feishu_comment.py plugins/platforms/feishu/feishu_comment_rules.pysucceeds