docs(tools-reference): fix stale feishu_comment.py path - #71371
Closed
santhiprakash wants to merge 1 commit into
Closed
docs(tools-reference): fix stale feishu_comment.py path#71371santhiprakash wants to merge 1 commit into
santhiprakash wants to merge 1 commit into
Conversation
- Problem: The tools-reference page references gateway/platforms/feishu_comment.py, but the feishu adapter was migrated to plugins/platforms/feishu/ in the platform-plugin migration (NousResearch#49408). - Fix: Update the path to plugins/platforms/feishu/feishu_comment.py to match the current codebase. - Verification: Confirmed target file exists at the new path and the old path no longer exists in gateway/platforms/.
alt-glitch
added
type/docs
Author
|
Closing in favor of consolidated PR covering all stale feishu path references (# coming). The three separate PRs were opened from an older branch that accumulated 360+ commits behind main and could not be cleanly rebased. All three fixes (tools-reference EN, tools-reference zh-Hans, feishu guide EN/zh-Hans, feishu_comment_rules.py usage, adapter.py docstring) are included in the replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Built-in Tools Reference page references
gateway/platforms/feishu_comment.pyas the location of the Feishu document-comment handler. That path is stale — the feishu adapter was migrated fromgateway/platforms/toplugins/platforms/feishu/in the platform-plugin migration (#49408).Root cause
Line 67 of
website/docs/reference/tools-reference.mdstill uses the pre-migration path.Fix
gateway/platforms/feishu_comment.py→plugins/platforms/feishu/feishu_comment.pyto match the current codebase location.Verification
plugins/platforms/feishu/feishu_comment.pyexists onupstream/main(commit6ad632bf9)gateway/platforms/feishu_comment.pydoes not exist ingateway/platforms/(only legacy adapters remain there)gateway/platforms/references in the website docs are stale — all other referenced files still exist at their documented paths