Drop the leftover session counts inside an entered project - #72912
Merged
Merged
Conversation
The sidebar's flat session list lost its `x/<total>` chip in #72336, but the project drill-in kept counting: WorkspaceHeader still rendered a SidebarCount for every repo and every branch/worktree lane. Entering a project put a number next to each label again. Remove the header's count slot and both call sites, along with the now dead repo total.
Contributor
૮ >ﻌ< ა ci reviewran on e04ed64 all good! |
alt-glitch
added
type/feature
OutThisLife
added a commit
that referenced
this pull request
Jul 28, 2026
#72336 removed the count from the flat list and #72912 from the entered project, but three sites still tallied rows: search results, each messaging group (Telegram, Discord, …), and cron jobs. With them gone SidebarCount never renders a count — its one caller is the projects-loading spinner — so rename it SidebarSectionMeta.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…oject-count Drop the leftover session counts inside an entered project
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered project, but three sites still tallied rows: search results, each messaging group (Telegram, Discord, …), and cron jobs. With them gone SidebarCount never renders a count — its one caller is the projects-loading spinner — so rename it SidebarSectionMeta.
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…oject-count Drop the leftover session counts inside an entered project
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered project, but three sites still tallied rows: search results, each messaging group (Telegram, Discord, …), and cron jobs. With them gone SidebarCount never renders a count — its one caller is the projects-loading spinner — so rename it SidebarSectionMeta.
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…oject-count Drop the leftover session counts inside an entered project
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered project, but three sites still tallied rows: search results, each messaging group (Telegram, Discord, …), and cron jobs. With them gone SidebarCount never renders a count — its one caller is the projects-loading spinner — so rename it SidebarSectionMeta.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…oject-count Drop the leftover session counts inside an entered project
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered project, but three sites still tallied rows: search results, each messaging group (Telegram, Discord, …), and cron jobs. With them gone SidebarCount never renders a count — its one caller is the projects-loading spinner — so rename it SidebarSectionMeta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flat sidebar session list lost its count chip in #72336, but the project drill-in never did. Entering a project still put a number beside every repo header and every branch/worktree lane, because
WorkspaceHeaderkept its ownSidebarCountslot.This removes that slot, the two call sites that fed it, and the repo total that existed only to fill it.