Skip to content

Quieter status bar and sidebar counts - #72336

Merged
OutThisLife merged 2 commits into
mainfrom
bb/statusbar-prefs
Jul 27, 2026
Merged

OutThisLife merged 2 commits into
mainfrom
bb/statusbar-prefs

Conversation

@OutThisLife

Copy link
Copy Markdown
Contributor

Two changes to what the desktop chrome shows by default, both aimed at surfaces that were reporting numbers and controls nobody asked for.

Sidebar counts

Sections and workspace lanes labelled themselves loaded/total, which reads as a progress bar people expect to fill up rather than a count of loaded rows. Pricing that label cost a COUNT(*) per profile database on every sidebar refresh, purely so the numerator and denominator could differ.

Pagination only needs to know whether another page exists, and that falls out of the rows the query already returned: a window that comes back full means more remain on disk. Sections now show the loaded count alone, and the backend reports per-profile profiles_truncated flags in place of total / profile_totals. "Load more" behaves the same; the per-refresh counting is gone.

Status bar

The bar shipped every affordance it had, so approvals, the terminal toggle, agents, cron and webhooks sat there permanently for users who never touched them. Those five now start hidden, and right-clicking the bar opens a menu to turn them back on. The choice persists per install.

Items opt into the menu by naming themselves with toggleLabel, so a plugin contribution that doesn't opt in always shows. The system icon and the version/update pills are listed but locked on — hiding the way back into settings would strand the user, and update state isn't a preference. Preferences store the hidden set rather than the visible one, so an item added to the bar in a later version appears for existing users instead of staying silently off.

Covered by statusbar-visibility.test.tsx: defaults, toggling through the menu, the locked items, and pass-through for items that never opted in.

The sidebar labelled sections and workspace lanes `loaded/total`, which
read as a progress bar people expected to fill up rather than a count of
loaded rows. Pricing that label cost a COUNT(*) per profile database on
every sidebar refresh, purely so the numerator and denominator could
differ.

Pagination only needs to know whether another page exists, and that comes
free from the rows the query already returned: a window that comes back
full means more remain on disk. Sections now show the loaded count alone,
and the backend reports per-profile `profiles_truncated` flags in place of
`total` / `profile_totals`.
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) comp/cli CLI entry point, hermes_cli/, setup wizard sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state labels Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on c5336b4

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

1 visual diff.

inline evidence is publishing...

The status bar shipped every affordance it had, so approvals, the terminal
toggle, agents, cron and webhooks sat there permanently for users who never
touched them.

Those five now start hidden and the bar owns a context menu that turns them
back on, persisted per install. Items opt in by naming themselves with
`toggleLabel`, so a plugin contribution that doesn't opt in always shows;
the system icon and the version/update pills are listed but locked on,
since hiding the way back into settings strands the user.

Preferences store the hidden set rather than the visible one, so an item
added to the bar in a later version appears for existing users instead of
staying silently off.
@OutThisLife
OutThisLife merged commit e1ace0a into main Jul 27, 2026
90 of 92 checks passed
@OutThisLife
OutThisLife deleted the bb/statusbar-prefs branch July 27, 2026 01:10
afourniernv pushed a commit to afourniernv/hermes-agent that referenced this pull request Jul 27, 2026
The sidebar's flat session list lost its `x/<total>` chip in NousResearch#72336, but
the project drill-in kept counting: WorkspaceHeader still rendered a
SidebarCount for every repo and every branch/worktree lane. Entering a
project put a number next to each label again.

Remove the header's count slot and both call sites, along with the now
dead repo total.
OutThisLife added a commit that referenced this pull request Jul 28, 2026
#72336 removed the count from the flat list and #72912 from the entered
project, but three sites still tallied rows: search results, each
messaging group (Telegram, Discord, …), and cron jobs.

With them gone SidebarCount never renders a count — its one caller is
the projects-loading spinner — so rename it SidebarSectionMeta.
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…prefs

Quieter status bar and sidebar counts
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
The sidebar's flat session list lost its `x/<total>` chip in NousResearch#72336, but
the project drill-in kept counting: WorkspaceHeader still rendered a
SidebarCount for every repo and every branch/worktree lane. Entering a
project put a number next to each label again.

Remove the header's count slot and both call sites, along with the now
dead repo total.
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered
project, but three sites still tallied rows: search results, each
messaging group (Telegram, Discord, …), and cron jobs.

With them gone SidebarCount never renders a count — its one caller is
the projects-loading spinner — so rename it SidebarSectionMeta.
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
The sidebar's flat session list lost its `x/<total>` chip in NousResearch#72336, but
the project drill-in kept counting: WorkspaceHeader still rendered a
SidebarCount for every repo and every branch/worktree lane. Entering a
project put a number next to each label again.

Remove the header's count slot and both call sites, along with the now
dead repo total.
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered
project, but three sites still tallied rows: search results, each
messaging group (Telegram, Discord, …), and cron jobs.

With them gone SidebarCount never renders a count — its one caller is
the projects-loading spinner — so rename it SidebarSectionMeta.
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
…prefs

Quieter status bar and sidebar counts
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
The sidebar's flat session list lost its `x/<total>` chip in NousResearch#72336, but
the project drill-in kept counting: WorkspaceHeader still rendered a
SidebarCount for every repo and every branch/worktree lane. Entering a
project put a number next to each label again.

Remove the header's count slot and both call sites, along with the now
dead repo total.
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered
project, but three sites still tallied rows: search results, each
messaging group (Telegram, Discord, …), and cron jobs.

With them gone SidebarCount never renders a count — its one caller is
the projects-loading spinner — so rename it SidebarSectionMeta.
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…prefs

Quieter status bar and sidebar counts
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
The sidebar's flat session list lost its `x/<total>` chip in NousResearch#72336, but
the project drill-in kept counting: WorkspaceHeader still rendered a
SidebarCount for every repo and every branch/worktree lane. Entering a
project put a number next to each label again.

Remove the header's count slot and both call sites, along with the now
dead repo total.
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
NousResearch#72336 removed the count from the flat list and NousResearch#72912 from the entered
project, but three sites still tallied rows: search results, each
messaging group (Telegram, Discord, …), and cron jobs.

With them gone SidebarCount never renders a count — its one caller is
the projects-loading spinner — so rename it SidebarSectionMeta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants