fix(pairing): add user_id-based approve for undelivered pairing codes (#70651) - #71256
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(pairing): add user_id-based approve for undelivered pairing codes (#70651)#71256kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
…NousResearch#70651) Add PairingStore.approve_by_user_id() and a --user-id / -u flag to 'hermes pairing approve' so operators can approve pending requests by user_id when the pairing code was never delivered (e.g. dropped DM, rate-limited reply on Weixin/WeChat bridges). Closes NousResearch#70651
alt-glitch
added
type/bug
Collaborator
1 task
Contributor
Author
|
Closing due to merge conflicts that need to be resolved before this can be merged. The PR has been marked as CONFLICTING by GitHub — please rebase on the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
PairingStore.approve_by_user_id()and a--user-id/-uflag tohermes pairing approveso operators can approve pending requests byuser_idwhen the pairing code was never delivered (e.g. dropped DM, rate-limited reply on Weixin/WeChat bridges).Changes
gateway/pairing.py: Addedapprove_by_user_id()— looks up pending entries byuser_idand approves without needing the hashed pairing codehermes_cli/pairing.py:_cmd_approvenow acceptsuser_id_modeparameter; delegates toapprove_by_user_idwhen--user-idis passedhermes_cli/subcommands/pairing.py: Added--user-id/-uflag to the approve subcommandTest Plan
Closes #70651