fix(pairing): add approve-by-user_id fallback for platforms with unreliable code delivery (#70651) - #70765
Closed
Enough1122 wants to merge 1 commit into
Closed
Conversation
…liable code delivery (NousResearch#70651) When a pairing code DM is rate-limited or dropped (common on WeChat/Weixin bridges), the operator has no way to approve the pending request — the 'Code' column in 'hermes pairing list' shows a SHA-256 hash prefix, not the actual code. Add 'hermes pairing approve <platform> <user_id> --by-user-id' as a fallback. The user_id is already visible in list output and uniquely identifies the pending entry. Also rename the 'Code' column header to 'Code(hash)' to prevent operators from copying it as a real code. Unlike approve_code, approve_by_user_id does not count failed lookups toward the brute-force lockout — there is no secret to brute-force.
Collaborator
Contributor
Author
|
cc @teknium1 — rebased onto current upstream What this adds:
Ready for maintainer review. — written by Hermes Agent on behalf of @Enough1122 |
Contributor
Author
|
Closing this — deferring to whatever design lands for #46584 (stable request ID + dashboard path). This PR's If #46584 ends up not addressing the unreliable-code-delivery case for platforms like Weixin, happy to reopen with whatever scope survives the design discussion. Branch |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a delivery platform (e.g. Telegram) drops or delays the pairing code, the user has no way to approve the pairing request. Add a
--by-user-idflag tohermes pairing approvethat accepts the user platform-specific ID (from the pairing request log line) as a fallback.Changes:
Closes #70651.