test(gateway): use a 16+ char API_SERVER_KEY in the explicit-disable env test - #70273
Closed
teknium1 wants to merge 1 commit into
Closed
test(gateway): use a 16+ char API_SERVER_KEY in the explicit-disable env test#70273teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
…env test 9e4b898 added a load-time strength gate (has_usable_secret, min_length=16) to the api_server env branch; the pre-existing test from c7fd3eb used the 11-char 'secret-key', so the branch is now skipped and the test fails on main and every open PR. Use a strong key so the test exercises the branch it was written to pin.
This was referenced Jul 23, 2026
alt-glitch
added
type/test
Contributor
૮ >ﻌ< ა ci reviewran on 3c9e2fd all good! |
13 tasks
Contributor
Author
|
Superseded by #70274, which landed the same fix (valid-length key) minutes ahead while this PR was in CI. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the test failure currently red on
mainand failing CI slice 4/8 on every open PR:test_env_key_does_not_reenable_explicitly_disabled_api_serveruses an 11-charAPI_SERVER_KEY, but 9e4b898 (merged this morning) added a load-time strength gate (has_usable_secret, min_length=16) to the api_server env branch — so the branch the test pins is now skipped entirely and itsextra["key"]assertion fails.Classic two-green-PRs collision: c7fd3eb's test and 9e4b898's gate each passed CI independently; the semantic conflict only manifests merged.
Changes
tests/gateway/test_config.py: use a 16+ char key so the test exercises the branch it was written to pin; comment explains the strength-gate dependency.Validation
tests/gateway/test_config.pyInfographic