test(gateway): use valid API server key fixture - #70272
Closed
embwl0x wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by maintainer PR #70273, which applies the same fixture correction and adds an explanatory strength-gate comment. Closing this duplicate and deferring to the maintainer-owned implementation. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The API-server enrollment hardening correctly rejects weak
API_SERVER_KEYvalues, but this older regression still usedsecret-key. The stale fixture made currentmainfail while asserting that the rejected key was stored.Validation
scripts/run_tests.sh tests/gateway/test_config.py— 148 passed, 1 failedscripts/run_tests.sh tests/gateway/test_config.py— 149 passedscripts/run_tests.sh tests/gateway/test_api_server.py tests/gateway/test_platform_connected_checkers.py— 247 passed.venv/bin/ruff check tests/gateway/test_config.pygit diff --checkFixes #70268