feat(desktop): keyboard navigation for clarify choices - #69799
Merged
Conversation
5 tasks
Contributor
૮ >ﻌ< ა ci reviewran on c63cd3c ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence is publishing... |
Collaborator
OutThisLife
force-pushed
the
bb/salvage-69497-clarify-sanitize
branch
from
July 23, 2026 03:30
2927797 to
b4c985b
Compare
OutThisLife
force-pushed
the
bb/salvage-64346-clarify-kbnav
branch
from
July 23, 2026 03:30
e79e3ad to
f3c67c6
Compare
OutThisLife
force-pushed
the
bb/salvage-69497-clarify-sanitize
branch
from
July 23, 2026 03:51
b4c985b to
e3e3492
Compare
OutThisLife
force-pushed
the
bb/salvage-64346-clarify-kbnav
branch
from
July 23, 2026 03:52
f3c67c6 to
4a4743a
Compare
OutThisLife
force-pushed
the
bb/salvage-69497-clarify-sanitize
branch
from
July 23, 2026 04:26
e3e3492 to
215550c
Compare
OutThisLife
force-pushed
the
bb/salvage-64346-clarify-kbnav
branch
from
July 23, 2026 04:41
4a4743a to
c63cd3c
Compare
OutThisLife
enabled auto-merge (squash)
July 23, 2026 04:42
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…ch#69799) Co-authored-by: Mapurite <272619650+mapu-og@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #64346 by @mapu-og (Mapurite; cherry-picked, authorship preserved).
Re-authored onto the merged
ChoiceButton(#69769) and the sanitized choicepipeline (#69497) — the original edited the pre-refactor inline
<button>.What it adds
A keyboard cursor over the clarify options on the live card:
free-text row (wraps around).
jumps into the "Other" field.
responds immediately; "Other" focuses the textarea).
aria-current,aria-keyshortcuts(e.g.A 1), anddata-highlightedon the active row.The global key handler stands down whenever a focusable control (any field,
choice button, or the action bar) already has focus, so it never eats keystrokes
meant for the composer, the Other box, or a tabbed-to button.
Tests
clarify-tool.test.tsx— arrow cycling + aria wiring, number-select + Enterconfirm (asserts the
clarify.respondpayload), Other focus leaves typing keysalone, and the handler yields while an action button is focused.
This is a feature (not a bugfix); it layers cleanly on top of the clarify
fixes. Stacked on #69796 → #69795; review/merge those first.
Supersedes #64346.