feat(desktop): improve Quick Choice keyboard navigation and history - #65778
Open
mapu-og wants to merge 6 commits into
Open
feat(desktop): improve Quick Choice keyboard navigation and history#65778mapu-og wants to merge 6 commits into
mapu-og wants to merge 6 commits into
Conversation
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved (read-only token — formal approval requires write access)
Improves Quick Choice keyboard navigation and history in the desktop app. Adds test coverage for clarify tool and keyboard interactions.
- Clean desktop UI improvement
- Good test additions for clarify-tool component
- No security concerns
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clarify/ Quick Choice cardsQuick Choice optionsdisclosureThe backend/tool name remains
clarify;Quick Choiceis presentation-only.Verification
npm run test: 205 files passed, 1726 tests passed, 1 skippednpm run typecheck: passednpm run test:desktop:all: passednpm run check: passed in the separated verification runnpx eslint src/components/assistant-ui/clarify-tool.tsx src/components/assistant-ui/clarify-tool.test.tsx: 0 errors (4 existingdocumentwarnings in tests)Testing notes
The isolated build was manually exercised with Quick Choice. Arrow navigation works with an empty composer without first clicking the card, Enter confirms the active choice, and the settled history exposes the offered options in a disclosure menu.