Skip to content

feat(desktop): improve Quick Choice keyboard navigation and history - #65778

Open
mapu-og wants to merge 6 commits into
NousResearch:mainfrom
mapu-og:feat/desktop-clarify-keyboard-navigation-upstream
Open

feat(desktop): improve Quick Choice keyboard navigation and history#65778
mapu-og wants to merge 6 commits into
NousResearch:mainfrom
mapu-og:feat/desktop-clarify-keyboard-navigation-upstream

Conversation

@mapu-og

@mapu-og mapu-og commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add keyboard navigation and numeric shortcuts to Desktop clarify / Quick Choice cards
  • scope global shortcuts to the active clarify card so multiple cards cannot answer at once
  • allow arrow navigation while the empty chat composer is focused, while preserving normal text-entry behavior once text exists
  • preserve offered choices in the settled chat history behind a Quick Choice options disclosure
  • serialize UI test files to avoid shared-state races in the full check suite

The backend/tool name remains clarify; Quick Choice is presentation-only.

Verification

  • npm run test: 205 files passed, 1726 tests passed, 1 skipped
  • npm run typecheck: passed
  • npm run test:desktop:all: passed
  • npm run check: passed in the separated verification run
  • npx eslint src/components/assistant-ui/clarify-tool.tsx src/components/assistant-ui/clarify-tool.test.tsx: 0 errors (4 existing document warnings in tests)
  • Desktop Linux unpacked artifact generated successfully

Testing notes

The isolated build was manually exercised with Quick Choice. Arrow navigation works with an empty composer without first clicking the card, Enter confirms the active choice, and the settled history exposes the offered options in a disclosure menu.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) needs-decision Awaiting maintainer decision before any implementation labels Jul 16, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved (read-only token — formal approval requires write access)

Improves Quick Choice keyboard navigation and history in the desktop app. Adds test coverage for clarify tool and keyboard interactions.

  • Clean desktop UI improvement
  • Good test additions for clarify-tool component
  • No security concerns

Reviewed by Hermes Agent

@teknium1 teknium1 added sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) needs-decision Awaiting maintainer decision before any implementation P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants