fix(telegram): preserve group authorization union - #69617
Closed
konsisumer wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing — |
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores the documented Telegram authorization union at the intake security boundary. A global
allow_fromuser may use the bot in groups, and eithergroup_allow_fromorgroup_allowed_chatscan grant group access without opening direct messages. The runner now applies the same config-only decision, so it cannot reject an event that intake accepted.Related Issue
Fixes #68716
Type of Change
Changes Made
gateway/authz_mixin.py: centralizes Telegram config allowlist evaluation and applies the global, group-user, and group-chat grants as an OR-union.plugins/platforms/telegram/adapter.py: uses that shared decision before event construction, batching, or observation.tests/gateway/test_telegram_auth_check.py: covers config and environment equivalence, each scoped grant, direct-message denial for group-only users, and preserved early rejection.How to Test
/opt/homebrew/bin/timeout -k 30 480 sh -c 'pytest tests/gateway/test_telegram_auth_check.py -q --timeout=60'.PATH="$VIRTUAL_ENV/bin:$PATH" /opt/homebrew/bin/timeout -k 30 480 sh -c 'pytest tests/ -q -x --timeout=60 "$@"' sh.What platforms tested on
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A