fix(telegram): accept scalar allowlist configuration

[visualfox-ch]

Summary

• accept scalar allow_from / allowlist values in Telegram configuration
• normalize scalar and sequence forms consistently
• isolate authorization tests from live environment allowlists

Test plan

• python -m pytest tests/gateway/test_telegram_auth_check.py tests/gateway/test_telegram_rich_messages.py -q -o 'addopts='
• ruff check plugins/platforms/telegram/adapter.py tests/gateway/test_telegram_auth_check.py

Split from and supersedes the Telegram portion of #50894.

[tonydwb]

Code Review Summary

Verdict: Approved

Fix for Telegram allowlist configuration to accept scalar values. Small (35 additions, 2 deletions). No security concerns.

---

Reviewed by Hermes Agent

[teknium1]

Thanks for isolating the scalar Telegram allowlist failure. Current main still directly iterates allow_from at plugins/platforms/telegram/adapter.py:931, while the configuration bridge preserves the raw configured value at gateway/config.py:1242-1243, so the integer-scalar bug is real.

Problems

• plugins/platforms/telegram/adapter.py:931 narrows the existing accepted input from arbitrary iterables to list. Before this change, tuple and set values were iterated into normalized IDs. With the proposed fallback, they are stringified and comma-split, yielding parenthesized/quoted tokens that no longer match. PlatformConfig.extra intentionally permits Any values (gateway/config.py:477).

Suggested changes

• Keep non-string iterable normalization while handling scalar strings/numbers separately, and add a tuple or set regression case next to the scalar tests.

This is an automated hermes-sweeper review.

[teknium1]

This narrows the prior behavior from any iterable to only list: tuples and sets previously normalized correctly but now reach the scalar str(...).split(",") path and no longer match their IDs. Please preserve non-string iterable handling while adding scalar support.

[GottZ]

This was generated by AI during triage.

Summary

Thirteen PRs address or reference three related Telegram authorization problems: the original missing user/group controls, YAML-versus-environment intake short-circuits for group and DM users, and preservation of the documented global/group/chat authorization union. Their diffs range from the merged gateway implementation in #17748 and focused adapter fixes in #55496/#55529 to scalar parsing coverage in #63350/#64473 and the broader union/multiplex work in #72084.

Related pull requests

• fix(telegram): add user-level access control for groups and DMs #7659 [closed] related — (+0/-0) — n/a: The original user-level access-control proposal has no remaining diff because its head branch was overwritten; it remains relevant as the predecessor superseded by fix(telegram): support group user allowlist #17686.
• feat: allow Telegram chat allowlists for groups and forums #15027 [merged] partial — (+30/-2) — n/a: This merged reference implementation added Telegram group/forum chat-ID authorization, but mapped group_allowed_chats through TELEGRAM_GROUP_ALLOWED_USERS, creating the compatibility concern later handled by fix(telegram): support group user allowlist (salvages #17686) #17748.
• fix(telegram): support group user allowlist #17686 [closed] fixes — (+222/-20) — n/a: This implemented distinct global-user, group-user, and group-chat authorization in the gateway; it is closed because its commit was cherry-picked with preserved authorship into fix(telegram): support group user allowlist (salvages #17686) #17748.
• fix(telegram): support group user allowlist (salvages #17686) #17748 [merged] best fix — (+369/-29) — n/a: This merged implementation salvaged fix(telegram): support group user allowlist #17686, closed the original Telegram: Missing user-level access control — any user can trigger bot via @mention in any group #7651 access-control gap, added documentation, and preserved feat: allow Telegram chat allowlists for groups and forums #15027-era chat-ID configurations through a deprecation shim.
• fix(telegram): honor group user allowlists #55496 partial — (+148/-6) — n/a: This fixes the group/forum intake short-circuit and bridges user-key aliases, but the contributor keep_open review requires preserving fail-closed semantics for an explicit empty allow_from before it is ready.
• fix(telegram): honor DM env allowlist when yaml allow_from is set #55529 best fix — (+176/-6) — n/a: The recorded best fix for [Bug]: TELEGRAM_ALLOWED_USERS and TELEGRAM_GROUP_ALLOWED_USERS not authorizing additional users in supergroups (even after disabling Privacy Mode) #55462 extends fix(telegram): honor group user allowlists #55496's fallback to the reported DM case and adds alias handling; consistent with the maintainer-bot keep_open verdict, its salvage path is to document the aliases and canonical-key precedence.
• fix(telegram): authorize TELEGRAM_GROUP_ALLOWED_USERS in group/forum chats (#55462) #55624 [closed] partial — (+605/-49) — n/a: This closed group/forum allowlist variant duplicates fix(telegram): honor group user allowlists #55496's core change while bundling malformed callback indentation and unrelated generated scripts; contributor review identifies fix(telegram): honor group user allowlists #55496 as the cleaner canonical fix.
• fix(gateway): honor group_allow_from for Telegram group/forum chats #57189 [closed] partial — (+17/-3) — n/a: This narrowly unions group_allow_from into the adapter intake gate, but it was closed in favor of the more complete fix(telegram): honor group user allowlists #55496/fix(telegram): honor DM env allowlist when yaml allow_from is set #55529 path that also handles aliases, chat-scoped authorization, and the DM half.
• test(telegram): pin comma-string allow_from / group_allow_from in adapter auth #63350 duplicate — (+56/-0) — n/a: This test-only PR adds comma-string, whitespace, group, and wildcard regressions after main independently gained scalar coercion, so its remaining value is focused parsing coverage rather than a production fix.
• fix(telegram): accept scalar allowlist configuration #64473 related — (+35/-2) — n/a: This fixes integer and comma-string allow_from parsing, but the contributor keep_open review shows the diff regresses previously accepted tuple/set iterables by stringifying them; retain the scalar tests while restoring generic iterable normalization.
• fix(telegram): don't let allow_from short-circuit group authorization (#68716) #68784 [closed] best fix — (+381/-38) — n/a: Although recorded as a best fix for [Bug] Telegram adapter allow_from short-circuits group-scoped authorization #68716, this closed deferral-based patch was superseded after current main at a0d2eba redesigned plugins/platforms/telegram/adapter.py to select authorization by chat type, making this diff structurally inapplicable.
• fix(telegram): preserve group authorization union #69617 [closed] partial — (+133/-37) — n/a: This closed attempt centralized the documented authorization union across intake and runner paths, but contributor review found that explicit empty config lists rejected existing group-gating cases; fix(telegram): preserve authorization union across group sources #72084 supersedes its incomplete approach.
• fix(telegram): preserve authorization union across group sources #72084 best fix — (+738/-67) — n/a: The recorded best fix for [Bug] Telegram adapter allow_from short-circuits group-scoped authorization #68716 preserves the full global/group/chat/environment/pairing union and adds multiplex profile scoping, but consistent with the maintainer-bot keep_open verdict it needs rebasing and focused salvage onto the moved intake and runner paths.

Duplicates

#7659 and #17686 are predecessors of merged #17748; #55624 and #57189 duplicate the group-side work led by #55496, while #55529 contains that path plus the complementary DM fix. #63350 overlaps #64473's comma-string regression coverage, and #68784/#69617 are superseded approaches to the authorization-union problem now addressed more comprehensively by #72084.

Suggested consolidation

Keep #55496 open with the explicit-empty fail-closed fix, keep recorded best fix #55529 open for alias documentation, and keep #63350 open only as salvageable focused regression coverage. Author action on #64473: preserve tuple/set iterable behavior and retain the scalar tests; author action on recorded best fix #72084: rebase onto current main or split out the current intake/runner authorization union and multiplex profile-scope pieces, while the already closed #68784 and #69617 remain historical/superseded and #55624/#57189 remain duplicates.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    subgraph Dup63350 ["PRs duplicating each other"]
        P63350["PR #63350 (open)"]
        P64473["PR #64473 (open)"]
    end
    class P63350 open
    class P64473 open
    class P64473 target
    click P63350 "https://github.com/NousResearch/hermes-agent/pull/63350"
    click P64473 "https://github.com/NousResearch/hermes-agent/pull/64473"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 13 pull requests and 3 issues in this complex. Each diff was read against this issue; Assessment working set: 189 kB of PR diffs, 30 kB of issue/PR text, 25 kB of discussion (42 comments), 16 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.