feat(observability): add Relay active install metrics - #69416
Merged
jquesnelle merged 22 commits intoAug 5, 2026
Merged
Conversation
Contributor
Author
|
Validation completed on the Category 1 stack tip:
|
19 tasks
afourniernv
force-pushed
the
feat/hermes-relay-install-activation-metrics
branch
from
July 22, 2026 15:30
4af564f to
5006fb2
Compare
Contributor
Author
|
Two scope clarifications from review:
I opened #69528 for the identity-scope decision. My recommendation for this local-first slice is to preserve the profile boundary and rename/document it as a random, resettable pseudonymous profile ID. Moving to a shared installation-level identity would first require explicit cross-profile consent, reset, deletion, and migration semantics. |
This was referenced Jul 26, 2026
afourniernv
force-pushed
the
feat/hermes-relay-install-activation-metrics
branch
3 times, most recently
from
July 29, 2026 01:48
68b2cdd to
e20d4a0
Compare
19 tasks
afourniernv
force-pushed
the
feat/hermes-relay-install-activation-metrics
branch
4 times, most recently
from
July 29, 2026 18:51
350803c to
21d5627
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/hermes-relay-install-activation-metrics
branch
from
July 29, 2026 19:21
21d5627 to
46bae75
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # hermes_cli/observability/schemas/hermes.shared_metrics.v1.schema.json # scripts/smoke_nemo_relay_shared_metrics.py # tests/agent/test_skill_commands.py # tests/hermes_cli/test_relay_shared_metrics.py # tests/hermes_cli/test_relay_shared_metrics_runtime.py # tests/tools/test_skill_manager_tool.py # tests/tools/test_skill_usage.py # tests/tools/test_skills_tool.py
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # docs/observability/relay-shared-metrics.md # hermes_cli/observability/shared_metrics.py # tests/hermes_cli/test_relay_shared_metrics.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # hermes_cli/observability/schemas/hermes.shared_metrics.v1.schema.json # hermes_cli/observability/shared_metrics_contract.py # hermes_cli/observability/shared_metrics_subscriber.py # scripts/smoke_nemo_relay_shared_metrics.py # tests/hermes_cli/test_relay_shared_metrics.py # tests/hermes_cli/test_relay_shared_metrics_runtime.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # tests/tools/test_skills_hub.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # tests/run_agent/test_run_agent.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
marked this pull request as ready for review
August 4, 2026 22:14
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…lay-install-activation-metrics feat(observability): add Relay active install metrics
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…lay-install-activation-metrics feat(observability): add Relay active install metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the remaining Category 1 install/activation slice on top of the Relay client-resource stack. Consented Hermes session and task starts now emit an empty Relay activation mark, and the profile-scoped subscriber records one pseudonymous client-active counter per rolling 24-hour window.
This is a stacked PR on #68978. Until the earlier PRs land, GitHub shows the cumulative stack against
main; the active-install-only diff is available here.Stack Order
Merge and review in this order. This PR is cumulative until its predecessors land on
main.Related Issue
Depends on #68978.
Type of Change
Changes Made
hermes.client.activeRelay mark from consented session and task boundaries.How to Test
scripts/run_tests.sh tests/hermes_cli/test_relay_shared_metrics.py tests/hermes_cli/test_relay_shared_metrics_runtime.py -q..venv/bin/python scripts/smoke_nemo_relay_shared_metrics.pywith the installed NeMo Relay binding.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
hermes.client.activecounter, a stable pseudonymous profile ID across packages, all prior aggregate families, schema validation, and privacy-canary checks.