feat(observability): add Relay client resource metrics - #68978
Merged
jquesnelle merged 15 commits intoAug 5, 2026
Merged
Conversation
afourniernv
force-pushed
the
feat/hermes-relay-client-dimensions
branch
from
July 22, 2026 14:27
a5bf137 to
ccfec97
Compare
This was referenced Jul 22, 2026
afourniernv
marked this pull request as ready for review
July 23, 2026 15:09
This was referenced Jul 26, 2026
afourniernv
force-pushed
the
feat/hermes-relay-client-dimensions
branch
3 times, most recently
from
July 29, 2026 01:48
86bcafe to
034c811
Compare
19 tasks
afourniernv
force-pushed
the
feat/hermes-relay-client-dimensions
branch
4 times, most recently
from
July 29, 2026 18:51
8587f5c to
f118dab
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/hermes-relay-client-dimensions
branch
from
July 29, 2026 19:21
f118dab to
5607d09
Compare
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the bounded-resource migration and compatibility coverage. I found two correctness gaps in the client-resource slice.
Problems
hermes_cli/observability/schemas/hermes.shared_metrics.v1.schema.json:52adds the new properties but leavesresource.requiredas onlyhermes_version(lines 43-45). The accompanying test intentionally preserves that (tests/hermes_cli/test_relay_shared_metrics.py:254-272), so schema validation does not enforce the claimed complete resource tuple.hermes_cli/observability/shared_metrics_subscriber.py:43passesdetect_install_method()directly into the new allowlist. The existing detector returnsnixfor/nix/storeinstalls (hermes_cli/config.py:475-482), but the PR's allowlist hasnixos, notnix, and normalizes unmatched values tounknown(hermes_cli/observability/shared_metrics_contract.py:188-231).
Suggested changes
- Version the strict resource schema while retaining compatibility validation for already-queued v1 packages, then test that new packages cannot omit any resource field.
- Normalize
nixexplicitly or add it to the contract and cover the subscriber path.
Automated hermes-sweeper review.
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # hermes_cli/observability/schemas/hermes.shared_metrics.v1.schema.json # scripts/smoke_nemo_relay_shared_metrics.py # tests/agent/test_skill_commands.py # tests/hermes_cli/test_relay_shared_metrics.py # tests/hermes_cli/test_relay_shared_metrics_runtime.py # tests/tools/test_skill_manager_tool.py # tests/tools/test_skill_usage.py # tests/tools/test_skills_tool.py
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # docs/observability/relay-shared-metrics.md # hermes_cli/observability/shared_metrics.py # tests/hermes_cli/test_relay_shared_metrics.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # tests/tools/test_skills_hub.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com> # Conflicts: # tests/run_agent/test_run_agent.py
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Signed-off-by: Alex Fournier <afournier@nvidia.com>
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…lay-client-dimensions feat(observability): add Relay client resource metrics
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…lay-client-dimensions feat(observability): add Relay client resource metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the Category 2 client-resource slice on top of the Relay skill-metrics stack. Shared-metrics packages now include bounded Hermes version, OS family, architecture, and install-method fields captured when each aggregate is recorded.
This is a stacked draft PR on #68883. Until the earlier PRs land, GitHub shows the cumulative stack against
main; the client-resource-only diff is available here.Stack Order
Merge and review in this order. This draft is cumulative until its predecessors land on
main.Related Issue
Depends on #68883.
Type of Change
Changes Made
unknown.unknownto newly introduced dimensions.How to Test
scripts/run_tests.sh tests/hermes_cli/test_relay_shared_metrics.py -q.scripts/run_tests.sh tests/hermes_cli/test_relay_shared_metrics_runtime.py tests/plugins/test_nemo_relay_plugin.py -q..venv/bin/python scripts/smoke_nemo_relay_shared_metrics.pywith the installed NeMo Relay binding.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
macos,arm64,giton the test host); privacy canaries remained absent.