fix(secrets): stop printing secret names during env load (salvage #60295) - #69054
Merged
Conversation
Contributor
૮ >ﻌ< ა ci reviewrunning on bb775a5 CI timingsCI timings · View jobWall time 8m14s vs 10m42s (-23.1%). 9 job(s) slower, 9 faster, 2 unchanged.
|
alt-glitch
added
type/security
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Startup no longer prints the NAMES of applied vault secrets —
applied 98 secrets (OPENAI_API_KEY, ...)becomesapplied 98 secrets. Secret names are enumeration surface (shoulder-surfing, shipped logs) with no operator value at startup;hermes secrets bitwarden syncstill shows the full table on demand.Clean cherry-pick of PR #60295 by @andrexibiza, incl. regression test asserting no name leakage.
Validation
Credit: @andrexibiza.
Infographic