Stop printing Bitwarden secret names during env load - #60295
Conversation
Reproduction steps for the current behavior on
|
|
Thanks for the focused security fix. Current main still emits the full applied-variable list from The added regression coverage exercises the normal external-source path with a mocked Bitwarden fetch and asserts both the retained status count and absence of supplied secret names. The same generic formatter is the only repository match for this applied-name formatting, so the change addresses the current startup disclosure site. The target files have not changed since PR base Automated hermes-sweeper review. |
|
Merged via #69054 — clean cherry-pick, your commit and regression test landed as-is. Thanks @andrexibiza! |
|
My pleasure, proud to be part of the crew!!!!!! |
Summary
Stops Hermes from printing the names of secrets applied from Bitwarden Secrets Manager during env loading.
Before:
Bitwarden Secrets Manager: applied 98 secrets (OPENAI_API_KEY, ... )After:
Bitwarden Secrets Manager: applied 98 secretsWhy
Secret names can reveal operational configuration and should not be dumped to terminal output or logs during startup.
Tests
python -m pytest tests/test_env_loader_secret_sources.py -qpython -m py_compile hermes_cli\env_loader.py