test(model): isolate custom-provider grouping tests from live discovery (salvages #62421) - #67921
Merged
Merged
Conversation
alt-glitch
added
type/test
Collaborator
Related to open #62421. This is a maintainer salvage of the same three-test hermeticity fix, so it is not marked duplicate; please choose the branch to merge. |
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three custom-provider grouping tests are now deterministic on hosts running a real Ollama at
localhost:11434. Salvages #62421 (@virtualex-itv) onto current main with authorship preserved.Changes
tests/hermes_cli/test_model_switch_custom_providers.py:probe_custom_providers=Falseon the three grouping tests whose fixtures point athttp://localhost:11434/v1— without it, a live Ollama's catalog replaces the fixture models and the tests assert against the host's install instead of the grouping invariant. Dedicated live-probe tests are unchanged.Validation
scripts/run_tests.sh tests/hermes_cli/test_model_switch_custom_providers.pyInfographic