test(model): isolate custom-provider grouping tests from live discovery - #62421
virtualex-itv wants to merge 1 commit into
Conversation
|
This is a sound, narrow test-isolation change. Current Dedicated live-probe coverage remains present at Automated hermes-sweeper review. |
3a528d1 to
3c2b0b0
Compare
3c2b0b0 to
72c0220
Compare
|
Rebased onto current main (a79b818); diff unchanged (+3), focused suite 41/41 green. |
|
Merged via PR #67921 — your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks for the clean hermeticity fix and the repro documentation! |
Summary
Problem
Three tests build custom-provider fixtures around
http://localhost:11434/v1and assert the configured model names, grouping, and total model count.list_authenticated_providers()may probe that endpoint by default. On a machine with Ollama listening there, live models replace the fixture models and the tests fail based on the host's current catalog rather than the invariant they are named for.On untouched
origin/main, the hermetic wrapper reproduced exactly three failures:test_list_authenticated_providers_groups_same_endpointtest_list_authenticated_providers_distinct_endpoints_stay_separatetest_list_authenticated_providers_total_models_reflects_grouped_countBaseline result: 38 passed, 3 failed.
Fix
Pass
probe_custom_providers=Falsein those three tests. This keeps their inputs limited to the configured fixtures while preserving live discovery coverage in the probe-specific tests elsewhere in the same file.Verification
Result:
git diff --checkpassedScope and risk