test(desktop): contract test — every cron helper is profile-scoped - #67602
Merged
Conversation
Salvaged from #59888 by @isfttr: the profileScoped() fix itself landed via #67493 (salvaged from the earlier #49948), but this PR contributed a contract test locking all 9 cron helpers to the active gateway profile — omitted when none is set (single-profile users unaffected), attached when one is active. Keeps the multi-profile/remote cron routing from silently regressing.
alt-glitch
added
type/test
Collaborator
Related to #47429: this is test-only contract coverage for the active-profile cron-helper behavior. |
This was referenced Jul 19, 2026
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a vitest contract test locking every desktop cron helper to
profileScoped(), so the multi-profile/remote cron routing fixed in #67493 can't silently regress. Salvaged from #59888 by @isfttr — his PR independently found and fixed the same missing-scope bug (#49948 → #67493 landed the fix first), but his contract test is a real addition we didn't have; authorship preserved.Changes
apps/desktop/src/hermes-cron-scope.test.ts(new): asserts all 9 cron helpers (list/get/runs/create/update/pause/resume/trigger/delete) omitprofilewhen none is active and attach it whensetApiRequestProfile()is set.contributors/emails/lucas.fernandes.df@gmail.com: contributor mapping for release attribution.Validation
npx vitest run src/hermes-cron-scope.test.tsInfographic