fix(desktop): scope messaging sidebar by profile

[HOYALIM]

Summary

• fetch messaging seed pages and per-platform pagination within the active profile
• keep cross-profile messaging only in the explicit All Profiles view
• keep messaging and cron sections visible when a profile has no normal sessions or projects

Why

The Desktop sidebar fetched messaging sessions with profile=all regardless of the selected profile, then hid every session section when the normal-session/project lists were empty. This could expose another profile’s Slack rows and make the messaging section appear only after creating a local chat.

Fixes #63593

Testing

• npm run test:ui --workspace apps/desktop -- src/app/session/hooks/use-session-list-actions.test.ts src/app/chat/sidebar/section-states.test.ts (6 passed)
• npm run typecheck --workspace apps/desktop
• npm exec --workspace apps/desktop -- eslint src/app/session/hooks/use-session-list-actions.ts src/app/session/hooks/use-session-list-actions.test.ts src/app/chat/sidebar/index.tsx src/app/chat/sidebar/section-states.tsx src/app/chat/sidebar/section-states.test.ts
• npm exec --workspace apps/desktop -- prettier --check src/app/session/hooks/use-session-list-actions.ts src/app/session/hooks/use-session-list-actions.test.ts src/app/chat/sidebar/index.tsx src/app/chat/sidebar/section-states.tsx src/app/chat/sidebar/section-states.test.ts

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[zidansilverlane-boop]

+1 on this approach. We hit the same bug on a Telegram-only secondary profile, independently traced it to the same two causes (profile=all seed fetch + sections hidden behind the workspace-grouping gate), and verified that fixing exactly those two things resolves it on a production two-profile setup (macOS, remote gateway). Scoping the fetch server-side is better than the client-side filter we used locally — it also keeps the per-platform totals honest.

[teknium1]

Thanks for tracing both the server fetch scope and the empty-section gate. The underlying bug is present on current main: use-session-list-actions.ts:102 and :126 fetch messaging with profile=all, and sidebar/index.tsx:1007 omits messaging/cron from its visibility condition.

Problems

• The new sidebar filter at apps/desktop/src/app/chat/sidebar/index.tsx:824 will hide all messaging rows in the existing persisted-All fallback. ALL_PROFILES is "__all__" (store/profile.ts:279), while showAllProfiles is deliberately false when only one profile remains (sidebar/index.tsx:261; commit 76b98f43). The comparison therefore rejects normal default rows.
• The newly scoped async messaging fetch at use-session-list-actions.ts:103 has no request-generation guard. A prior-profile response can arrive after the active profile's response and replace its messaging cache. The Desktop guide requires stale responses not to overwrite newer intent (apps/desktop/AGENTS.md:68-70).

Suggested changes

• Filter defensively only when profileScope !== ALL_PROFILES, and cover the persisted-All/single-profile fallback.
• Add a messaging refresh generation guard and an out-of-order profile-switch test.

Automated hermes-sweeper review.

[teknium1]

showAllProfiles is false when an All Profiles preference persists after the user returns to one profile (the intentional fallback from 76b98f4), but profileScope remains __all__. This condition then filters every normal default messaging row. Check profileScope !== ALL_PROFILES here instead, and add that fallback regression test.

[teknium1]

Profile changes can leave an earlier fetch in flight; without a request-generation guard, its later response can overwrite the newly selected profile's messaging cache. Mirror refreshSessionsRequestRef and test A/B requests resolving out of order.

[GottZ]

This was generated by AI during triage.

Summary

Eighteen PRs address or reference this issue complex: #42934, #56635, #58983, #60688, #63618, #70630, and #71526 change messaging/profile scoping; #42654, #47429, #51531, #52910, and #67615 cover cron/profile scoping; the remaining diffs address owner resolution, deletion races, bulk deletion, fetch failures, pin hydration, or messaging-page retention. For #63593 specifically, #63618 matches both reported causes by scoping messaging fetches and keeping messaging/cron sections visible without normal sessions.

Related pull requests

• fix(desktop): scope cron jobs sidebar to active profile #42654 [closed] partial — (+103/-15) — n/a: Scopes cron list/create calls through the active profile rather than the messaging and empty-sidebar paths; although closed, it remains relevant as the original approach salvaged into merged fix(desktop): scope the cron jobs list to the active profile #67615.
• fix(desktop): filter messaging sessions by active profile #42934 best fix — (+213/-10) — n/a: Scopes messaging seed and platform pagination, adds defensive profile filtering, and fences stale callbacks; its current diff addresses the contributor keep_open review’s ALL_PROFILES and profile-switch race concerns.
• fix(desktop): scope messaging sessions by profile #44157 partial — (+36/-11) — n/a: Scopes messaging reads and adds owner lookup for messaging/cron resume, but the contributor keep_open review requires porting those distinct changes from pre-refactor locations and adding current-path stale-response protection.
• fix(desktop): scope cron job calls by profile #47429 [closed] partial — (+99/-10) — n/a: Covers the full cron-helper routing surface rather than messaging visibility; although closed, it remains relevant because its routing/test intent landed through fix(cron): profile-scope desktop cron calls + resolve provider with the job's effective model #67493/test(desktop): contract test — every cron helper is profile-scoped #67602 and its endpoint-filter gap through fix(desktop): scope the cron jobs list to the active profile #67615.
• fix(desktop): prevent deleted sessions from reappearing #51210 best fix — (+473/-70) — n/a: Adds durable tombstone filtering and rollback across recents, cron, messaging, search, and pagination for the deletion-refresh race, a separate cause from profile leakage.
• fix(desktop): scope cron job list to the active profile #51531 [closed] partial — (+79/-2) — n/a: Adds endpoint-level active-profile filtering to the cron list and regression tests; although closed, it remains relevant as superseded by the landed fix(cron): profile-scope desktop cron calls + resolve provider with the job's effective model #67493/test(desktop): contract test — every cron helper is profile-scoped #67602/fix(desktop): scope the cron jobs list to the active profile #67615 sequence.
• fix(desktop): respect profile scope for cron jobs and messaging sessions #52910 best fix — (+14/-7) — n/a: Scopes cron and messaging calls, but the contributor keep_open review identifies obsolete DesktopController call sites and an _apiProfile-versus-sidebar-scope mismatch; fix(desktop): scope the cron jobs list to the active profile #67615 supersedes its cron half.
• feat(desktop): add "Delete all chats" button to the chat sidebar #55957 related — (+398/-2) — n/a: Implements profile-routed bulk deletion with bounded paging and failure reconciliation, which is adjacent session management rather than a fix for messaging scope or empty-section visibility.
• fix(desktop): scope messaging sidebar sessions to active profile #56635 partial — (+22/-4) — n/a: Changes messaging seed and pagination from all profiles to the active scope, but its contributor keep_open review identifies missing stale-result fencing, hook-level call-site coverage, and the remaining visibility gate.
• fix: scope desktop messaging sessions to active profile #58983 partial — (+155/-8) — n/a: Scopes messaging fetches and removes the grouping/empty-state suppression, but its contributor keep_open review identifies an unresolved out-of-order profile-response race.
• fix(desktop): resync pinned sessions from store #60019 [closed] related — (+343/-24) — n/a: Hydrates off-page pins in bounded ID batches while preserving compact/full response contracts; although closed, it remains relevant because Pins are server-owned, so they survive paging and follow you between apps #74234 superseded and carried this work.
• fix(desktop): scope messaging and cron session fetches to active profile #60688 best fix — (+25/-6) — n/a: Scopes cron-session, messaging-seed, and platform-pagination reads and adds request counters, while the contributor keep_open review still calls for scope-change regressions and safe handling of stale profile closures.
• fix(desktop): scope messaging sidebar by profile #63618 best fix — (+313/-27) — n/a: Fixes both Desktop messaging sidebar is globally scoped and hidden when active profile has no normal sessions #63593 causes by scoping messaging seed/pagination, filtering cached rows, guarding delayed responses, and counting messaging/cron toward sidebar visibility; despite the contributor keep_open review, the current diff directly covers its ALL_PROFILES and stale-response blockers with tests.
• fix(desktop): preserve session list on fetch failure instead of dropping to empty #64159 best fix — (+278/-8) — n/a: Separates observable cold-boot session-load failure from recoverable background failure while preserving stale rows, addressing a distinct empty-sidebar failure mode rather than profile leakage.
• fix(desktop): preserve expanded messaging pages across polling #65527 related — (+145/-2) — n/a: Reconciles capped messaging polls with expanded platform pages and fences overlapping refreshes, preventing page collapse but leaving profile selection outside this diff.
• fix(desktop): scope the cron jobs list to the active profile #67615 [merged] best fix — (+60/-7) — n/a: This merged reference implementation scopes cron-job lists in the sidebar and overlay with endpoint-level filtering, resolving the cron-list facet but not messaging-session scope or visibility.
• fix(desktop): scope sessions to selected profile #70630 best fix — (+466/-81) — n/a: Establishes a broader profile boundary across backend slices, fallback, Electron routing, renderer, search, pins, pagination, and stale responses, but the contributor keep_open review requires a current-main router port, reuse of session-index.ts, and preservation of OAuth-aware routing.
• fix(gateway): scope sidebar messaging sessions to the active profile #71526 best fix — (+412/-66) — n/a: Carries messaging scope through independent reads, the batched router, legacy fallback, Electron splice, renderer filtering, and profile-keyed totals; despite the contributor keep_open review, the current diff addresses its totals and moved-router objections, while contributor approval of repository CI remains outstanding.

Duplicates

#56635 and the core messaging-scoping portion of #58983 duplicate the same fetch changes covered more completely by #42934/#63618; the messaging portions of #44157, #52910, and #60688 overlap those call sites but retain distinct owner-resolution or cron-session work. #42654, #47429, and #51531 are superseded cron approaches whose relevant behavior is represented by merged #67615, while #70630 and #71526 are broader backend/routing implementations rather than exact duplicates.

Suggested consolidation

Keep #63618 open with a salvage path focused on its independently valuable empty-sidebar visibility logic plus its tested stale-response and ALL_PROFILES handling; coordinate the server-window and remote-routing contract with #71526 rather than retaining parallel messaging-scoping implementations. Close #56635 as a duplicate of #42934/#63618, narrow #58983 to any visibility work not already retained, narrow #44157 to current-path owner resolution and #60688 to cron-session scoping, and keep #70630 open only for a current-main salvage of the broader boundary that explicitly follows its contributor review.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I42915(["issue #42915 (open)"])
    I52401(["issue #52401 (open)"])
    I56631(["issue #56631 (open)"])
    I60678(["issue #60678 (open)"])
    I63593(["issue #63593 (open)"])
    I65710(["issue #65710 (open)"])
    I70629(["issue #70629 (open)"])
    P63618["PR #63618 (open)"]
    P63618 -->|fixes| I42915
    P63618 -.->|partial| I52401
    P63618 -->|fixes| I56631
    P63618 -.->|partial| I60678
    P63618 -->|best fix| I63593
    P63618 -->|fixes| I65710
    P63618 -.->|partial| I70629
    class I42915 open
    class I52401 open
    class I56631 open
    class I60678 open
    class I63593 open
    class I65710 open
    class I70629 open
    class P63618 open
    class P63618 best
    class P63618 target
    click I42915 "https://github.com/NousResearch/hermes-agent/issues/42915"
    click I52401 "https://github.com/NousResearch/hermes-agent/issues/52401"
    click I56631 "https://github.com/NousResearch/hermes-agent/issues/56631"
    click I60678 "https://github.com/NousResearch/hermes-agent/issues/60678"
    click I63593 "https://github.com/NousResearch/hermes-agent/issues/63593"
    click I65710 "https://github.com/NousResearch/hermes-agent/issues/65710"
    click I70629 "https://github.com/NousResearch/hermes-agent/issues/70629"
    click P63618 "https://github.com/NousResearch/hermes-agent/pull/63618"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 18 pull requests and 11 issues in this complex. Each diff was read against this issue; Assessment working set: 281 kB of PR diffs, 79 kB of issue/PR text, 63 kB of discussion (67 comments), 86 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

[teknium1]

The profile-scoping half of this PR landed on main via #87566. What survives here: the section-visibility gate (section-states.tsx — keeping messaging/cron sections visible for profiles with no regular sessions); main's showSessionSections still only counts sessions+projects. Leaving open for that half — a rebase onto current main would slim this down to just the gate change.