Skip to content

fix(nix): include apps/shared in TUI source filter (#67079) - #67475

Closed
kyssta-exe wants to merge 1 commit into
NousResearch:mainfrom
kyssta-exe:auto-fix/issue-67079
Closed

fix(nix): include apps/shared in TUI source filter (#67079)#67475
kyssta-exe wants to merge 1 commit into
NousResearch:mainfrom
kyssta-exe:auto-fix/issue-67079

Conversation

@kyssta-exe

Copy link
Copy Markdown
Contributor

Description

The TUI imports from @hermes/shared/charge-settlement (added in PR #61067), but the Nix TUI source filter in nix/tui.nix only included ui-tui. The apps/shared workspace dependency was missing, causing esbuild to fail when resolving the @hermes/shared/charge-settlement import.

nix/web.nix and nix/desktop.nix already include apps/shared in their dirs list for the same reason — this fix adds it to nix/tui.nix to match.

Fixes #67079, #67056

The TUI imports from @hermes/shared/charge-settlement (added in PR NousResearch#61067),
but apps/shared was missing from the Nix TUI source filter, causing esbuild
to fail when resolving the workspace dependency. web.nix and desktop.nix
already include apps/shared for the same reason.

Fixes NousResearch#67079, NousResearch#67056
@alt-glitch alt-glitch added type/bug Something isn't working comp/tui Terminal UI (ui-tui/ + tui_gateway/) area/nix Nix flake, NixOS module, container packaging P2 Medium — degraded but workaround exists sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades duplicate This issue or pull request already exists labels Jul 19, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of open #67082: both add apps/shared to nix/tui.nix for the same Nix TUI build failure. #67090 is the same later variant.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Nix packaging fix. Current main still declares @hermes/shared in ui-tui/package.json:22 and imports @hermes/shared/charge-settlement in ui-tui/src/app/slash/commands/topup.ts:1, while nix/tui.nix:4 scopes the filtered source to only ui-tui. nix/lib.nix:221-225,248 defines dirs as the workspace-source scope and explicitly requires file-dependency directories to be listed.

The added apps/shared directory matches the existing Nix patterns in nix/web.nix:4-10 and nix/desktop.nix:20-26. The PR remains cleanly mergeable; remote-main comparison from its base contains only an unrelated Desktop formatting commit.

Automated hermes-sweeper review.

@teknium1 teknium1 added the sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform label Jul 19, 2026
@kyssta-exe

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #67082 (alt-glitch triage confirmed). The same Nix TUI build fix is already tracked there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nix Nix flake, NixOS module, container packaging comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TUI fails to build in nix environment

3 participants