Skip to content

fix(nix): include apps/shared in TUI source filter - #67090

Closed
archdex-art wants to merge 2 commits into
NousResearch:mainfrom
archdex-art:fix/nix-tui-source-filter
Closed

fix(nix): include apps/shared in TUI source filter#67090
archdex-art wants to merge 2 commits into
NousResearch:mainfrom
archdex-art:fix/nix-tui-source-filter

Conversation

@archdex-art

Copy link
Copy Markdown

Fixes #67056

Adds apps/shared to the dirs list in nix/tui.nix so that the Nix TUI derivation includes the local workspace dependency.

@alt-glitch alt-glitch added type/bug Something isn't working comp/tui Terminal UI (ui-tui/ + tui_gateway/) area/nix Nix flake, NixOS module, container packaging P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jul 18, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #67082: the live one-line Nix TUI source-filter patch is byte-equivalent. #67082 remains the earlier open implementation.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused fix. The premise is confirmed on current main: nix/tui.nix:4 filters the TUI source to only ui-tui, while ui-tui/package.json:22 declares @hermes/shared as a file:../apps/shared dependency and ui-tui/src/app/slash/commands/topup.ts:1 imports from it. nix/lib.nix:221-225 documents that such workspace dependencies must be included in dirs.

This patch is byte-equivalent to the earlier open implementation in #67082, as noted in the existing triage comment. No code-level correction is requested.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nix Nix flake, NixOS module, container packaging comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Nix TUI source filter omits @hermes/shared sources

3 participants