Skip to content

fix(runner): whitelist Windows profile and temp vars in hermetic env #67407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dany-aspire wants to merge 1 commit into from
Closed

fix(runner): whitelist Windows profile and temp vars in hermetic env #67407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ exec env -i \
LANG=C.UTF-8 \
LC_ALL=C.UTF-8 \
PYTHONHASHSEED=0 \
PYTHONUTF8=1 \

@teknium1 teknium1 Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allowlist is reached only after venv discovery. Current scripts/run_tests.sh:46-53 requires bin/activate and bin/python, so a standard native-Windows Scripts/activate venv exits at lines 61-64 before this line runs unless HERMES_PYTHON is supplied. Please add the guarded Scripts/ probe included by related #67387.

${USERPROFILE:+USERPROFILE="$USERPROFILE"} \
${HOMEDRIVE:+HOMEDRIVE="$HOMEDRIVE"} \
${HOMEPATH:+HOMEPATH="$HOMEPATH"} \
${SYSTEMROOT:+SYSTEMROOT="$SYSTEMROOT"} \
${TEMP:+TEMP="$TEMP"} \
${TMP:+TMP="$TMP"} \
${HERMES_RUN_SLOW_PET_TESTS:+HERMES_RUN_SLOW_PET_TESTS="$HERMES_RUN_SLOW_PET_TESTS"} \
${EXTRA_PYTHONPATH:+PYTHONPATH="$EXTRA_PYTHONPATH"} \
${EXTRA_PYTEST_PLUGINS:+PYTEST_PLUGINS="$EXTRA_PYTEST_PLUGINS"} \
Expand Down