fix(runner): whitelist Windows profile and temp vars in hermetic env - #67407
fix(runner): whitelist Windows profile and temp vars in hermetic env#67407dany-aspire wants to merge 1 commit into
Conversation
Related: #67387 already covers this environment passthrough and additionally supports the native Windows venv layout. This focused subset remains related rather than a duplicate so maintainers can choose the preferred scope. |
teknium1
left a comment
There was a problem hiding this comment.
Thanks for isolating the Windows environment allowlist issue.
Problems
scripts/run_tests.sh:46-53only recognizes a POSIX venv (bin/activate, thenbin/python). A standard native-Windows venv usesScripts/activateandScripts/python.exe, so the runner reaches the error atscripts/run_tests.sh:61-64before the newenv -ipassthrough at this PR's added line 101 can execute. The member-linked #67387 already carries the requiredScripts/probe alongside the same allowlist change.
Suggested changes
- Include a guarded
Scripts/activate/Scripts/python.exevenv path, then keep the proposed Windows environment passthrough andPYTHONUTF8=1change.
Automated hermes-sweeper review.
| LANG=C.UTF-8 \ | ||
| LC_ALL=C.UTF-8 \ | ||
| PYTHONHASHSEED=0 \ | ||
| PYTHONUTF8=1 \ |
There was a problem hiding this comment.
This allowlist is reached only after venv discovery. Current scripts/run_tests.sh:46-53 requires bin/activate and bin/python, so a standard native-Windows Scripts/activate venv exits at lines 61-64 before this line runs unless HERMES_PYTHON is supplied. Please add the guarded Scripts/ probe included by related #67387.
Fixes #67385.
Problem
On native Windows, fails because strips , , , , , and variables, causing test collection crashes whenever tests touch or write temporary files. Consoles also fail when encoding tick glyphs.
Fix