Skip to content

fix(kanban): report and document actual unblock status - #66503

Closed
helix4u wants to merge 2 commits into
NousResearch:mainfrom
helix4u:fix/kanban-unblock-status-docs
Closed

fix(kanban): report and document actual unblock status#66503
helix4u wants to merge 2 commits into
NousResearch:mainfrom
helix4u:fix/kanban-unblock-status-docs

Conversation

@helix4u

@helix4u helix4u commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes kanban_unblock report and document the status that the database actually assigns. An unblocked task moves to ready only when all parents are done; otherwise it remains dependency-gated in todo.

The handler previously returned status="ready" unconditionally, and its schema, CLI help, and two documentation tables repeated that guarantee even though kanban_db.unblock_task() deliberately routes tasks with unfinished parents to todo.

This preserves Dusk1e's original fix and commit authorship from #28728, then completes the requested schema and documentation updates.

Related Issue

Supersedes #28728

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • Return the task's persisted post-unblock status from tools/kanban_tools.py.
  • Add regression coverage for unblocking a child whose parent is still open.
  • Describe the ready/todo routing accurately in the tool schema and docstring.
  • Align the CLI help and Kanban tool reference/user guide with the database behavior.

How to Test

  1. Create a parent task and a blocked child linked to that parent.
  2. Call kanban_unblock for the child while the parent is unfinished.
  3. Confirm both the tool response and persisted task status are todo; the existing happy-path coverage confirms a task without unfinished parents returns ready.

Local verification performed: python -m compileall -q tools/kanban_tools.py hermes_cli/kanban.py and git diff --check. Pytest was not run locally due the workstation's test-runner safety restriction; the targeted regression test is included for CI.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Windows 11 (static verification)

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

Not applicable.

@helix4u
helix4u force-pushed the fix/kanban-unblock-status-docs branch from 2adf359 to effc063 Compare July 17, 2026 20:17
@alt-glitch alt-glitch added type/bug Something isn't working comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jul 17, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #28728 — both return the persisted kanban_unblock status rather than hard-coding ready. This PR additionally updates the surrounding documentation and schema wording.

@helix4u

helix4u commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

This was generated by AI during triage.

Duplicate of #28728 — both return the persisted kanban_unblock status rather than hard-coding ready. This PR additionally updates the surrounding documentation and schema wording.

any way we can do these after ready to review and not in draft? same question with the classifier. and would love it if it identified new docs gaps introduced in a PR.

@helix4u
helix4u force-pushed the fix/kanban-unblock-status-docs branch from effc063 to 6ce1c93 Compare July 17, 2026 20:23
@helix4u
helix4u marked this pull request as ready for review July 17, 2026 20:30
@teknium1

Copy link
Copy Markdown
Contributor

Merged via #66571 (rebase, so your docs(kanban): clarify unblock status routing commit and Dusk1e's original fix are both preserved in history). Added a follow-up commit documenting the recurrence→triage loop-breaker at the human-facing lifecycle level, since that was the actual source of the reporter's 'unpredictable triage' confusion. Thanks @helix4u and @Dusk1e.

@teknium1 teknium1 closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants