You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Makes kanban_unblock report and document the status that the database actually assigns. An unblocked task moves to ready only when all parents are done; otherwise it remains dependency-gated in todo.
The handler previously returned status="ready" unconditionally, and its schema, CLI help, and two documentation tables repeated that guarantee even though kanban_db.unblock_task() deliberately routes tasks with unfinished parents to todo.
This preserves Dusk1e's original fix and commit authorship from #28728, then completes the requested schema and documentation updates.
🐛 Bug fix (non-breaking change that fixes an issue)
✨ New feature (non-breaking change that adds functionality)
🔒 Security fix
📝 Documentation update
✅ Tests (adding or improving test coverage)
♻️ Refactor (no behavior change)
🎯 New skill (bundled or hub)
Changes Made
Return the task's persisted post-unblock status from tools/kanban_tools.py.
Add regression coverage for unblocking a child whose parent is still open.
Describe the ready/todo routing accurately in the tool schema and docstring.
Align the CLI help and Kanban tool reference/user guide with the database behavior.
How to Test
Create a parent task and a blocked child linked to that parent.
Call kanban_unblock for the child while the parent is unfinished.
Confirm both the tool response and persisted task status are todo; the existing happy-path coverage confirms a task without unfinished parents returns ready.
Local verification performed: python -m compileall -q tools/kanban_tools.py hermes_cli/kanban.py and git diff --check. Pytest was not run locally due the workstation's test-runner safety restriction; the targeted regression test is included for CI.
Duplicate of #28728 — both return the persisted kanban_unblock status rather than hard-coding ready. This PR additionally updates the surrounding documentation and schema wording.
Duplicate of #28728 — both return the persisted kanban_unblock status rather than hard-coding ready. This PR additionally updates the surrounding documentation and schema wording.
any way we can do these after ready to review and not in draft? same question with the classifier. and would love it if it identified new docs gaps introduced in a PR.
Merged via #66571 (rebase, so your docs(kanban): clarify unblock status routing commit and Dusk1e's original fix are both preserved in history). Added a follow-up commit documenting the recurrence→triage loop-breaker at the human-facing lifecycle level, since that was the actual source of the reporter's 'unpredictable triage' confusion. Thanks @helix4u and @Dusk1e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/cronCron scheduler and job managementduplicateThis issue or pull request already existsP3Low — cosmetic, nice to havetype/bugSomething isn't working
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
kanban_unblockreport and document the status that the database actually assigns. An unblocked task moves toreadyonly when all parents are done; otherwise it remains dependency-gated intodo.The handler previously returned
status="ready"unconditionally, and its schema, CLI help, and two documentation tables repeated that guarantee even thoughkanban_db.unblock_task()deliberately routes tasks with unfinished parents totodo.This preserves Dusk1e's original fix and commit authorship from #28728, then completes the requested schema and documentation updates.
Related Issue
Supersedes #28728
Type of Change
Changes Made
tools/kanban_tools.py.ready/todorouting accurately in the tool schema and docstring.How to Test
kanban_unblockfor the child while the parent is unfinished.todo; the existing happy-path coverage confirms a task without unfinished parents returnsready.Local verification performed:
python -m compileall -q tools/kanban_tools.py hermes_cli/kanban.pyandgit diff --check. Pytest was not run locally due the workstation's test-runner safety restriction; the targeted regression test is included for CI.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Not applicable.