fix(tools/kanban): sync kanban_unblock response status with DB state - #28728
Closed
Dusk1e wants to merge 1 commit into
Closed
fix(tools/kanban): sync kanban_unblock response status with DB state#28728Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the focused regression fix. The premise is confirmed on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
19 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kanban_unblockinstead of always reportingreadyWhy
kanban_unblockcould reportreadyeven when the DB correctly re-gated the task totodo, which made the tool response inconsistent with actual board state.Testing
scripts/run_tests.sh tests/tools/test_kanban_tools.py -k unblock