Skip to content

fix(tools/kanban): sync kanban_unblock response status with DB state - #28728

Closed
Dusk1e wants to merge 1 commit into
NousResearch:mainfrom
Dusk1e:fix/kanban-unblock-tool-status-sync
Closed

fix(tools/kanban): sync kanban_unblock response status with DB state#28728
Dusk1e wants to merge 1 commit into
NousResearch:mainfrom
Dusk1e:fix/kanban-unblock-tool-status-sync

Conversation

@Dusk1e

@Dusk1e Dusk1e commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return the actual task status from kanban_unblock instead of always reporting ready
  • add a regression test covering blocked child tasks with unfinished parents

Why

kanban_unblock could report ready even when the DB correctly re-gated the task to todo, which made the tool response inconsistent with actual board state.

Testing

  • scripts/run_tests.sh tests/tools/test_kanban_tools.py -k unblock
  
============================== 5 passed in 3.41s ==============================

@alt-glitch alt-glitch added type/bug Something isn't working comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have labels May 19, 2026
@teknium1

teknium1 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for the focused regression fix. The premise is confirmed on current main: tools/kanban_tools.py:1074-1077 calls unblock_task() but always returns status="ready", while hermes_cli/kanban_db.py:5079-5107 deliberately persists todo for tasks with unfinished parents. The added tool-level test covers the missing response contract above the existing DB-layer state-transition test at tests/hermes_cli/test_kanban_db.py:1425-1449.

Problems

  • The change leaves model-facing schema text stale: tools/kanban_tools.py:1562-1572 still tells agents that unblocking returns a task to ready.
  • User/reference docs have the same stale guarantee at website/docs/reference/tools-reference.md:133 and website/docs/user-guide/features/kanban.md:276. The event reference already states the correct ready or todo outcome at website/docs/user-guide/features/kanban.md:905.

Suggested changes

  • Update the handler docstring/schema and the two documentation entries to describe the parent-gated ready/todo result.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 13, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Superseded and merged via #66571 — your response-status fix (return the persisted status instead of hardcoding ready) is preserved in history via rebase. Thanks @Dusk1e.

@teknium1 teknium1 closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants