feat(mcp): add Comfy Cloud to the MCP catalog with curated 20-tool default (salvage #57308) - #66112
Conversation
Related to #57308: this salvage keeps the Comfy Cloud catalog entry but adds a curated default tool selection, so it is not a duplicate. @christian-byrne Tagging you on this ComfyUI item. |
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Adds Comfy Cloud to MCP catalog with curated 20-tool default, salvage of #57308 (83 additions / 0 deletions). New MCP server catalog entry.
No security issues. Clean additive change. Small scope.
Reviewed by Hermes Agent (cron batch 2026-07-17)
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
PR #66112 feat(mcp): add Comfy Cloud to the MCP catalog with curated 20-tool default (salvage #57308)
Assessment
- Correctness: New MCP catalog entry for Comfy Cloud hosted service. manifest.yaml correctly uses Streamable HTTP transport with native MCP OAuth 2.1 + Dynamic Client Registration. The Hermes MCP client handles PKCE, token exchange, and refresh automatically.
- Scope: 82-line manifest.yaml file. Very focused addition.
- Security: Note that
report_session_summaryis deliberately excluded (outbound telemetry). Follows Hermes policy of no telemetry without explicit opt-in. Token scope is appropriately limited (20 curated tools instead of all 37, reducing per-request schema overhead). - No issues found
Reviewed by Hermes Agent
aad7eee to
90b9aef
Compare
…Auth 2.1) New catalog entry for Comfy Cloud's hosted remote MCP server at https://cloud.comfy.org/mcp — Streamable HTTP with native MCP OAuth 2.1 (Dynamic Client Registration + PKCE), the same shape as the linear entry. Nothing to install locally; Hermes's MCP client handles discovery and the browser flow on first connect. The server exposes ~30 tools for AI generation on Comfy Cloud: image / video / audio / 3D via ComfyUI workflows (submit_workflow), curated templates (run_template), and partner models like Flux, Kling, and Veo (partner_generate), plus job lifecycle and discovery tools. tools.default_enabled is left unset so the install-time checklist starts all-on, mirroring the linear entry. Also adds the per-entry data-files target in pyproject.toml per the one-target-per-entry pattern documented there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… line - tools.default_enabled: 20-tool curated subset (discovery, generation, job lifecycle, billing). The server exposes ~37 tools; all-enabled adds ~16-22k tokens of schema to every API call — larger than the entire Hermes core toolset (~12.7k). Curated default lands at ~9-12k. Batch, saved/shared workflow, and App Mode tools remain opt-in via 'hermes mcp configure comfy-cloud'. - report_session_summary excluded from defaults per telemetry policy (no outbound telemetry without explicit user opt-in). - description trimmed to catalog guideline length. - revert pyproject data-files line: the per-entry packaging enforcement was removed (no-pip policy); blender/unreal-engine entries have no data-files lines either.
90b9aef to
708ea5c
Compare
૮ >ﻌ< ა ci reviewran on 708ea5c ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) debug info |
Summary
Adds Comfy Cloud to the Nous MCP catalog with a curated 20-tool default — salvage of #57308 by @mattmillerai (Comfy), authorship preserved via cherry-pick.
Comfy Cloud ships a first-party hosted remote MCP server (
https://cloud.comfy.org/mcp, Streamable HTTP + native OAuth 2.1/DCR/PKCE — same shape as thelinearentry).hermes mcp install comfy-cloud→ browser sign-in → generate images/video/audio/3D on Comfy Cloud GPUs.Changes
optional-mcps/comfy-cloud/manifest.yaml: catalog entry (contributor commit), then curated on top:tools.default_enabled: 20-tool subset — discovery (7), generation (5), job lifecycle (6), billing + canvas handoff (2). The server exposes ~37 tools; at Hermes's measured ~600 tokens/tool schema average, all-enabled adds ~16–22k tokens to every API call while enabled — more than the entire Hermes core toolset (12.7k measured). Curated default lands at ~9–12k. Everything else stays opt-in viahermes mcp configure comfy-cloud.report_session_summaryexcluded per telemetry policy (no outbound telemetry without explicit opt-in);submit_feedback, App Mode tools,cql,get_server_info, batch variants, saved/shared workflow management unchecked by default.pyproject.tomldata-files line — per-entry packaging enforcement was removed (no-pip policy);blender/unreal-enginehave no such lines.scripts/release.py: AUTHOR_MAP entry formattmiller@comfy.org→@mattmillerai.Validation
_parse_manifest+list_catalog+get_entry("official/comfy-cloud")+_build_server_config(real imports){'url': 'https://cloud.comfy.org/mcp', 'auth': 'oauth'}GET /mcp/health200; RFC 9728 OAuth metadata servedtests/hermes_cli/test_mcp_catalog.py+tests/test_packaging_metadata.pyReplaces #57308 (will be closed with credit). Companion skill-routing PR follows separately (#65243 salvage).
Infographic