Skip to content

feat(mcp): add Comfy Cloud to the MCP catalog with curated 20-tool default (salvage #57308) - #66112

Merged
teknium1 merged 3 commits into
mainfrom
salvage/57308-comfy-cloud-mcp
Jul 30, 2026
Merged

feat(mcp): add Comfy Cloud to the MCP catalog with curated 20-tool default (salvage #57308)#66112
teknium1 merged 3 commits into
mainfrom
salvage/57308-comfy-cloud-mcp

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Adds Comfy Cloud to the Nous MCP catalog with a curated 20-tool default — salvage of #57308 by @mattmillerai (Comfy), authorship preserved via cherry-pick.

Comfy Cloud ships a first-party hosted remote MCP server (https://cloud.comfy.org/mcp, Streamable HTTP + native OAuth 2.1/DCR/PKCE — same shape as the linear entry). hermes mcp install comfy-cloud → browser sign-in → generate images/video/audio/3D on Comfy Cloud GPUs.

Changes

  • optional-mcps/comfy-cloud/manifest.yaml: catalog entry (contributor commit), then curated on top:
    • tools.default_enabled: 20-tool subset — discovery (7), generation (5), job lifecycle (6), billing + canvas handoff (2). The server exposes ~37 tools; at Hermes's measured ~600 tokens/tool schema average, all-enabled adds ~16–22k tokens to every API call while enabled — more than the entire Hermes core toolset (12.7k measured). Curated default lands at ~9–12k. Everything else stays opt-in via hermes mcp configure comfy-cloud.
    • report_session_summary excluded per telemetry policy (no outbound telemetry without explicit opt-in); submit_feedback, App Mode tools, cql, get_server_info, batch variants, saved/shared workflow management unchecked by default.
    • Description trimmed to catalog guideline (≤60 chars).
    • Dropped the PR's pyproject.toml data-files line — per-entry packaging enforcement was removed (no-pip policy); blender/unreal-engine have no such lines.
  • scripts/release.py: AUTHOR_MAP entry for mattmiller@comfy.org@mattmillerai.

Validation

Check Result
_parse_manifest + list_catalog + get_entry("official/comfy-cloud") + _build_server_config (real imports) pass — 20 default tools parsed, {'url': 'https://cloud.comfy.org/mcp', 'auth': 'oauth'}
Live server GET /mcp/health 200; RFC 9728 OAuth metadata served
tests/hermes_cli/test_mcp_catalog.py + tests/test_packaging_metadata.py pass

Replaces #57308 (will be closed with credit). Companion skill-routing PR follows separately (#65243 salvage).

Infographic

Comfy Cloud MCP catalog entry

@alt-glitch alt-glitch added type/feature New feature or request comp/tools Tool registry, model_tools, toolsets tool/mcp MCP client and OAuth P3 Low — cosmetic, nice to have labels Jul 17, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related to #57308: this salvage keeps the Comfy Cloud catalog entry but adds a curated default tool selection, so it is not a duplicate. @christian-byrne Tagging you on this ComfyUI item.

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment

Adds Comfy Cloud to MCP catalog with curated 20-tool default, salvage of #57308 (83 additions / 0 deletions). New MCP server catalog entry.

No security issues. Clean additive change. Small scope.


Reviewed by Hermes Agent (cron batch 2026-07-17)

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

PR #66112 feat(mcp): add Comfy Cloud to the MCP catalog with curated 20-tool default (salvage #57308)

Assessment

  • Correctness: New MCP catalog entry for Comfy Cloud hosted service. manifest.yaml correctly uses Streamable HTTP transport with native MCP OAuth 2.1 + Dynamic Client Registration. The Hermes MCP client handles PKCE, token exchange, and refresh automatically.
  • Scope: 82-line manifest.yaml file. Very focused addition.
  • Security: Note that report_session_summary is deliberately excluded (outbound telemetry). Follows Hermes policy of no telemetry without explicit opt-in. Token scope is appropriately limited (20 curated tools instead of all 37, reducing per-request schema overhead).
  • No issues found

Reviewed by Hermes Agent

mattmillerai and others added 3 commits July 29, 2026 19:26
…Auth 2.1)

New catalog entry for Comfy Cloud's hosted remote MCP server at
https://cloud.comfy.org/mcp — Streamable HTTP with native MCP OAuth 2.1
(Dynamic Client Registration + PKCE), the same shape as the linear entry.
Nothing to install locally; Hermes's MCP client handles discovery and the
browser flow on first connect.

The server exposes ~30 tools for AI generation on Comfy Cloud: image /
video / audio / 3D via ComfyUI workflows (submit_workflow), curated
templates (run_template), and partner models like Flux, Kling, and Veo
(partner_generate), plus job lifecycle and discovery tools.
tools.default_enabled is left unset so the install-time checklist starts
all-on, mirroring the linear entry.

Also adds the per-entry data-files target in pyproject.toml per the
one-target-per-entry pattern documented there.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… line

- tools.default_enabled: 20-tool curated subset (discovery, generation,
  job lifecycle, billing). The server exposes ~37 tools; all-enabled adds
  ~16-22k tokens of schema to every API call — larger than the entire
  Hermes core toolset (~12.7k). Curated default lands at ~9-12k. Batch,
  saved/shared workflow, and App Mode tools remain opt-in via
  'hermes mcp configure comfy-cloud'.
- report_session_summary excluded from defaults per telemetry policy
  (no outbound telemetry without explicit user opt-in).
- description trimmed to catalog guideline length.
- revert pyproject data-files line: the per-entry packaging enforcement
  was removed (no-pip policy); blender/unreal-engine entries have no
  data-files lines either.
@teknium1
teknium1 force-pushed the salvage/57308-comfy-cloud-mcp branch from 90b9aef to 708ea5c Compare July 30, 2026 02:26
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 708ea5c

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

1 visual diff.

inline evidence upload failed.

Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso)

debug info

MCP catalog security review

MCP catalog security review · View job

ci-reviewed label is present.

@teknium1 teknium1 added the ci-reviewed applied to manually approve dangerous changes label Jul 30, 2026
@teknium1
teknium1 merged commit 0524ecc into main Jul 30, 2026
69 of 72 checks passed
@teknium1
teknium1 deleted the salvage/57308-comfy-cloud-mcp branch July 30, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-reviewed applied to manually approve dangerous changes comp/tools Tool registry, model_tools, toolsets mcp-catalog-reviewed P3 Low — cosmetic, nice to have tool/mcp MCP client and OAuth type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants