Skip to content

feat(skills): comfyui v5.2.0 — route to Comfy Cloud MCP first, local for 24GB+ setups - #65243

Open
mattmillerai wants to merge 1 commit into
NousResearch:mainfrom
mattmillerai:comfyui-skill-cloud-mcp-routing
Open

feat(skills): comfyui v5.2.0 — route to Comfy Cloud MCP first, local for 24GB+ setups#65243
mattmillerai wants to merge 1 commit into
NousResearch:mainfrom
mattmillerai:comfyui-skill-cloud-mcp-routing

Conversation

@mattmillerai

Copy link
Copy Markdown
Contributor

What

Teaches the bundled comfyui skill (v5.1.0 → v5.2.0) to route between the Comfy Cloud MCP server (#57308) and this skill's CLI/REST path, instead of pretending the MCP doesn't exist.

Adds a "Route First: Comfy Cloud MCP vs. This Skill" section with the decision logic:

  1. Default to the Comfy Cloud MCP (hermes mcp install comfy-cloud) — one-command install, browser OAuth, no local compute. Especially when the machine is a Mac or the local GPU has < 24 GB VRAM.
  2. Offer local only when it's genuinely viable — 24 GB+ VRAM and an existing local ComfyUI setup → ask the user local vs. cloud.
  3. If the user picks local, set expectations (slower) and let this skill handle instance discovery + model/node installs (comfyui_setup.sh, auto_fix_deps.py).
  4. MCP and this skill are alternatives, not layers — pick one per task; don't mix MCP tool calls with the skill's CLI/REST scripts against the same job.

The skill's existing API-key Cloud path (Path A) is kept and explicitly repositioned as the headless / CI / scripted route where a browser OAuth flow isn't available. A short pointer in Setup & Onboarding sends interactive cloud users to the routing section before the Step 0 local-vs-cloud script runs.

Why

The skill currently treats "Comfy Cloud" purely as an API-key REST target. With comfy-cloud in the MCP catalog (#57308), the easiest cloud path for interactive Hermes users is the MCP — but without routing guidance the agent has two overlapping Comfy surfaces and no rule for choosing, which is exactly how an agent ends up installing ComfyUI locally on an 8 GB MacBook. This encodes the intended split: MCP by default, local only where the hardware and an existing setup justify it. Same shape as the blender-mcp skill's curated-tool-surface framing (#65116).

Changes

  • skills/creative/comfyui/SKILL.md — new "Route First" section after When to Use; onboarding pointer; version 5.2.0
  • website/docs/user-guide/skills/bundled/creative/creative-comfyui.md — regenerated page updated in lockstep (verbatim body embed + version in metadata table). Happy to re-run website/scripts/generate-skill-docs.py on the maintainer side if CI prefers generator output byte-for-byte.

Validation

Result
SKILL.md frontmatter parses clean, version: 5.2.0
Skill body ↔ docs page embed verbatim parity (modulo existing ascii-guard comments / MDX escaping)
New section content no raw <, {, or MDX-hostile constructs

Notes

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) labels Jul 15, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

@christian-byrne Tagging you on this ComfyUI item.

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the intended MCP/CLI split. The existing API-key fallback remains accurately preserved by the new text.

Problems

  • skills/creative/comfyui/SKILL.md:82 documents hermes mcp install comfy-cloud, but current main has no optional-mcps/comfy-cloud entry. hermes_cli/mcp_picker.py:309-316 rejects catalog names that get_entry() cannot resolve. This must remain coupled to #57308, which is still open.
  • The English source and generated page gain MCP-first routing, but website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/user-guide/skills/bundled/creative/creative-comfyui.md:220-246 still instructs users to choose API-key Cloud versus local first.

Suggested changes

  • Salvage after #57308 is present on the target branch, and update the zh-Hans counterpart to preserve one routing policy across published docs.

Automated hermes-sweeper review.

## Route First: Comfy Cloud MCP vs. This Skill

Hermes can also drive Comfy Cloud through the `comfy-cloud` MCP server from
the Nous-approved catalog (`hermes mcp install comfy-cloud`) — a hosted

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current main has no optional-mcps/comfy-cloud manifest, and install_by_name() rejects absent catalog entries in hermes_cli/mcp_picker.py:309-316. This instruction needs to land only with or after #57308.


(If you haven't already routed between the Comfy Cloud MCP and this skill,
do that first — see **Route First** above. Interactive cloud users are
usually better served by `hermes mcp install comfy-cloud` than by this

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the zh-Hans ComfyUI page as well: it still says the first decision is API-key Cloud versus local, so it conflicts with this new MCP-first routing guidance.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/skills Skills system (list, view, manage) type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants