feat(skills): comfyui v5.2.0 — route to Comfy Cloud MCP first, local for 24GB+ setups - #65243
Open
mattmillerai wants to merge 1 commit into
Open
feat(skills): comfyui v5.2.0 — route to Comfy Cloud MCP first, local for 24GB+ setups#65243mattmillerai wants to merge 1 commit into
mattmillerai wants to merge 1 commit into
Conversation
…local only for 24GB+ setups
Collaborator
@christian-byrne Tagging you on this ComfyUI item. |
teknium1
reviewed
Jul 16, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for documenting the intended MCP/CLI split. The existing API-key fallback remains accurately preserved by the new text.
Problems
skills/creative/comfyui/SKILL.md:82documentshermes mcp install comfy-cloud, but current main has nooptional-mcps/comfy-cloudentry.hermes_cli/mcp_picker.py:309-316rejects catalog names thatget_entry()cannot resolve. This must remain coupled to #57308, which is still open.- The English source and generated page gain MCP-first routing, but
website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/user-guide/skills/bundled/creative/creative-comfyui.md:220-246still instructs users to choose API-key Cloud versus local first.
Suggested changes
- Salvage after #57308 is present on the target branch, and update the zh-Hans counterpart to preserve one routing policy across published docs.
Automated hermes-sweeper review.
| ## Route First: Comfy Cloud MCP vs. This Skill | ||
|
|
||
| Hermes can also drive Comfy Cloud through the `comfy-cloud` MCP server from | ||
| the Nous-approved catalog (`hermes mcp install comfy-cloud`) — a hosted |
Contributor
There was a problem hiding this comment.
Current main has no optional-mcps/comfy-cloud manifest, and install_by_name() rejects absent catalog entries in hermes_cli/mcp_picker.py:309-316. This instruction needs to land only with or after #57308.
|
|
||
| (If you haven't already routed between the Comfy Cloud MCP and this skill, | ||
| do that first — see **Route First** above. Interactive cloud users are | ||
| usually better served by `hermes mcp install comfy-cloud` than by this |
Contributor
There was a problem hiding this comment.
Please update the zh-Hans ComfyUI page as well: it still says the first decision is API-key Cloud versus local, so it conflicts with this new MCP-first routing guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Teaches the bundled
comfyuiskill (v5.1.0 → v5.2.0) to route between the Comfy Cloud MCP server (#57308) and this skill's CLI/REST path, instead of pretending the MCP doesn't exist.Adds a "Route First: Comfy Cloud MCP vs. This Skill" section with the decision logic:
hermes mcp install comfy-cloud) — one-command install, browser OAuth, no local compute. Especially when the machine is a Mac or the local GPU has < 24 GB VRAM.comfyui_setup.sh,auto_fix_deps.py).The skill's existing API-key Cloud path (Path A) is kept and explicitly repositioned as the headless / CI / scripted route where a browser OAuth flow isn't available. A short pointer in Setup & Onboarding sends interactive cloud users to the routing section before the Step 0 local-vs-cloud script runs.
Why
The skill currently treats "Comfy Cloud" purely as an API-key REST target. With
comfy-cloudin the MCP catalog (#57308), the easiest cloud path for interactive Hermes users is the MCP — but without routing guidance the agent has two overlapping Comfy surfaces and no rule for choosing, which is exactly how an agent ends up installing ComfyUI locally on an 8 GB MacBook. This encodes the intended split: MCP by default, local only where the hardware and an existing setup justify it. Same shape as the blender-mcp skill's curated-tool-surface framing (#65116).Changes
skills/creative/comfyui/SKILL.md— new "Route First" section after When to Use; onboarding pointer; version 5.2.0website/docs/user-guide/skills/bundled/creative/creative-comfyui.md— regenerated page updated in lockstep (verbatim body embed + version in metadata table). Happy to re-runwebsite/scripts/generate-skill-docs.pyon the maintainer side if CI prefers generator output byte-for-byte.Validation
version: 5.2.0<,{, or MDX-hostile constructsNotes
hermes mcp install comfy-cloudcommand this references lands there; merge that first (or together).