fix(slack): silence WARNING+404 for unhandled Bolt events - #6580
Closed
ygd58 wants to merge 3 commits into
Closed
Conversation
…ty-aware platform notes
YAML 1.1 parses bare 'off' as boolean False, not the string 'off'. StreamingConfig.from_dict() now normalizes bool → string so that transport: off and transport: false both correctly disable streaming. Also guard the run.py check against boolean False as a safety net. Fixes NousResearch#6558
ygd58
force-pushed
the
fix/slack-unhandled-event-warnings
branch
from
April 9, 2026 13:08
ccbc1cb to
c7e51f4
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6572
Root Cause
gateway/platforms/slack.pyonly registers handlers formessageandapp_mention. Any other event the Slack app is subscribed to (e.g.reaction_added) falls through to slack_bolt's default unhandled-request handler, which emitsWARNING + 404for every such event — roughly 1:1 with real traffic.Fix
Register a catch-all no-op handler with
re.compile(r".*")after the existing handlers. Unhandled events are silently acknowledged and logged atDEBUGlevel instead of triggering the bolt WARNING.Changes
gateway/platforms/slack.py: add catch-all_ignore_unhandled_eventhandler