Skip to content

fix: silence unused Slack events - #36062

Closed
lennies wants to merge 1 commit into
NousResearch:mainfrom
lennies:fix/slack-unused-events-noise-25292a0
Closed

fix: silence unused Slack events#36062
lennies wants to merge 1 commit into
NousResearch:mainfrom
lennies:fix/slack-unused-events-noise-25292a0

Conversation

@lennies

@lennies lennies commented May 31, 2026

Copy link
Copy Markdown

Summary

  • Register no-op Slack event handlers for unused channel/reaction events.
  • Prevent Bolt from logging noisy "Unhandled request" warnings for expected events.
  • Add regression coverage that the handlers are registered.

Test Plan

  • python -m pytest tests/gateway/test_slack.py -q

@lennies

lennies commented May 31, 2026

Copy link
Copy Markdown
Author

Closing this PR because this was a local ops patch path, not intended as an upstream contribution right now.

@lennies lennies closed this May 31, 2026
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/slack Slack app adapter P3 Low — cosmetic, nice to have labels May 31, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix for #6572 (same root cause as #6580). Also see #33111 which registers reaction handlers via gateway hooks. Author indicated this was a local patch, not upstream contribution.

@mxnstrexgl mxnstrexgl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — automated review passed. No security, quality, or test coverage issues detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have platform/slack Slack app adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants