fix: add usedforsecurity=False to hashlib in tools/ and plugins/ (FIPS compliance)

[AlexFucuson9]

Summary

Add usedforsecurity=False to hashlib.sha256/md5/sha1 calls in tools/ and plugins/ that were missing it.

Problem

Python's hashlib defaults usedforsecurity=True, which causes a ValueError crash on FIPS-compliant systems (RHEL 8+, Ubuntu FIPS mode, AWS GovCloud):

ValueError: [digital envelope routines] unsupported

Changes (18 files, 19 call sites)

run_agent.py — name sanitization + image URL cache key (2 sites)

tools/:

• tirith_security.py — file integrity hash
• tool_result_storage.py — result ID dedup
• checkpoint_manager.py — path fingerprint
• web_tools.py — URL cache key
• approval.py — reason hash

plugins/platforms/:

• discord/adapter.py — payload verification
• line/adapter.py — access token fingerprint
• feishu/adapter.py — webhook signature verification
• whatsapp/adapter.py — file hash fingerprint

plugins/memory/:

• honcho/oauth_flow.py — PKCE challenge
• honcho/session.py — peer ID hash
• honcho/client.py — ID fingerprint
• holographic/holographic.py — word digest

plugins/other:

• teams_pipeline/store.py — canonical hash
• dashboard_auth/basic/__init__.py — SIG_LEN constant
• dashboard_auth/self_hosted/__init__.py — PKCE challenge
• dashboard_auth/nous/__init__.py — PKCE challenge

Not changed

• hashlib.scrypt (password hashing) — does not support usedforsecurity parameter
• hmac.new(..., hashlib.sha256) calls — hmac.new does not support the parameter in Python 3.10-3.11

Risk

None — all calls are for cache keys, fingerprints, or deduplication. No-op on non-FIPS systems.

[teknium1]

Thanks for pursuing FIPS compatibility. The current implementation needs a narrower security classification before it is safe to salvage.

Problems

• plugins/platforms/feishu/adapter.py:3566-3586 verifies an inbound webhook signature, and plugins/dashboard_auth/nous/__init__.py:179-195 derives a PKCE S256 challenge. Both are security contexts, but the patch passes usedforsecurity=False, which Python documents as declaring a non-security use.
• CPython documents SHA-256 as always present; the documented FIPS-blockable constructor is MD5. Meanwhile non-security MD5 uses remain at tools/skills_sync.py:234 and tools/skills_hub.py:1363.
• The diff changes 18 production files without FIPS-focused regression coverage.

Suggested changes

• Keep normal SHA-256 for signature verification, PKCE, and integrity checks.
• Re-scope to verified non-security uses of algorithms that can be blocked, and add targeted restricted-hash tests.

Automated hermes-sweeper review.

[teknium1]

This computes the value used to authenticate an inbound Feishu webhook. usedforsecurity=False declares a non-security use, so this verification path should retain the normal SHA-256 constructor.

[teknium1]

This is the OAuth PKCE S256 code challenge, a security protocol value. Please keep normal SHA-256 here rather than marking the hash as non-security.

[GottZ]

This was generated by AI during triage.

Summary

Twenty-one PRs address or reference this cluster: most annotate non-security MD5/SHA-1 constructors for FIPS compatibility, while #39049, #43937, and #54617 address WeCom constant-time signature comparison; several broader SHA-256 sweeps also modify security-sensitive contexts without establishing that those changes are required.

Related pull requests

• hash: silence 19 bandit B324 weak-hash warnings (cache keys + protocol fields) #27368 related — (+19/-19) — n/a: Annotates 19 cache, fingerprint, and protocol-required MD5/SHA-1 sites, but the visible keep_open review requires rebasing relocated WeCom paths, covering current sibling sites, and narrowing the repository-wide scan claim.
• fix(wecom): use constant-time comparison for the callback signature #39049 related — (+7/-1) — n/a: Replaces WeCom's plain signature comparison with hmac.compare_digest, but edits the retired gateway path; the keep_open review requires retargeting plugins/platforms/wecom/wecom_crypto.py and adding a primitive-level regression test.
• fix(wecom): constant-time callback signature comparison #43937 related — (+44/-1) — n/a: Adds the same constant-time comparison plus spy and None-signature tests, but both production and test imports use the pre-relocation gateway path; its keep_open review requires moving them to the live plugin module.
• fix(skills_hub): pass usedforsecurity=False to md5 cache keys (FIPS compatibility) #48472 related — (+5/-5) — n/a: Adds usedforsecurity=False to all five visible Skills Hub MD5 cache-key constructors; the maintainer-bot keep_open verdict identifies this as salvageable with a mocked-FIPS regression covering all five paths.
• fix: add usedforsecurity=False to hashlib.md5() calls for FIPS compatibility #51962 [closed] related — (+10/-10) — n/a: Closed reference implementation for non-security MD5 annotations across compressor, Weixin, WeCom, Skills Hub, and Skills Sync, substantially superseded by the broader open fix(agent,tools,gateway,plugins): add usedforsecurity=False to non-security hashlib calls #52783.
• fix: add usedforsecurity=False to hashlib.sha256/sha1 calls for FIPS #51973 [closed] related — (+48/-48) — n/a: Closed broad SHA-256/SHA-1 reference sweep whose diff also marks PKCE, checksums, authentication fingerprints, and signature-related paths as non-security, so it remains relevant as evidence of the over-broad classification repeated by later PRs.
• fix(agent,tools,gateway,plugins): add usedforsecurity=False to non-security hashlib calls #52783 related — (+16/-16) — n/a: Consolidates MD5/SHA-1 annotations across eight files, but its keep_open review requires adding the omitted Skills Hub cache key, testing constructor options, and excluding the COS authorization digest pending explicit protocol/security verification.
• fix(tools,gateway,agent,plugins): add usedforsecurity=False to hashlib calls #52967 [closed] related — (+18/-18) — n/a: Closed v2 of fix(agent,tools,gateway,plugins): add usedforsecurity=False to non-security hashlib calls #52783 with the same core changes plus WeCom callback SHA-1; contributor discussion identifies it as a duplicate/superset of the earlier canonical open fix(agent,tools,gateway,plugins): add usedforsecurity=False to non-security hashlib calls #52783.
• fix(wecom): use hmac.compare_digest for webhook signature check #54617 related — (+32/-1) — n/a: Applies hmac.compare_digest to the live WeCom plugin path, but its keep_open review finds the added accept/reject tests do not enforce use of the constant-time primitive and requests a spy-based regression.
• fix: hashlib.md5 FIPS crash in context_compressor.py #56715 related — (+1/-1) — n/a: Adds usedforsecurity=False to the compressor deduplication MD5 call, a focused slice of fix(agent,tools,gateway,plugins): add usedforsecurity=False to non-security hashlib calls #52783; its keep_open review requests a mocked-constructor regression or explicit consolidation into the broader audit.
• fix: hashlib FIPS crash in gateway and tools modules #56719 related — (+13/-13) — n/a: Covers QQ Bot, Weixin, Yuanbao, and Skills Hub hashes, but its keep_open review requires separating the COS signing digest, adding FIPS-keyword coverage, and including omitted sibling sites.
• fix: add usedforsecurity=False to hashlib md5/sha1 in skills_hub, skills_sync, web_server #62654 related — (+8/-8) — n/a: Covers five Skills Hub cache keys, Skills Sync directory hashing, and two web-server action-name hashes; the maintainer-bot keep_open verdict confirms the sites and asks for a focused constructor regression and corrected complementary-slice description.
• fix: hashlib FIPS crash in qqbot, wecom, yuanbao_media (md5/sha1 without usedforsecurity=False) #64062 related — (+8/-8) — n/a: Covers QQ Bot and WeCom upload checksums plus WeCom callback and COS signing hashes, but its keep_open review requires retaining only confirmed non-security uses and resolving both signature paths separately.
• fix: hashlib FIPS crash + assert→runtime guards in 4 production files #64808 related — (+6/-4) — n/a: Combines two valid non-security hash annotations with unrelated assert replacements; its keep_open review requires removing the unreachable TUI fallback, covering the sibling compact_thread assertion, and adding tests.
• fix: hashlib FIPS crash in skills_sync, weixin, web_server (usedforsecurity=False) #65434 related — (+5/-5) — n/a: Covers Weixin checksums, Skills Sync hashing, and web-server action names, but the maintainer-bot keep_open verdict requires adding the five omitted Skills Hub cache keys and a mocked-FIPS regression.
• fix: add usedforsecurity=False to hashlib calls in agent/ (FIPS compliance) #65561 related — (+11/-10) — n/a: Broadly marks agent-side SHA-256 uses including PKCE, checksum verification, and fingerprints as non-security; the diff does not distinguish security-context SHA-256 from cache/dedup uses or add restricted-runtime tests.
• fix: add usedforsecurity=False to hashlib in tools/ and plugins/ (FIPS compliance) #65570 related — (+20/-19) — n/a: Broadly marks tools/plugin SHA-256 uses, including Feishu signature verification and PKCE, as non-security; its keep_open review requires removing security-context changes, narrowing to verified blockable non-security hashes, and adding focused restricted-hash tests.
• fix: add usedforsecurity=False to hashlib.md5 in weixin adapter (FIPS crash) #66857 related — (+2/-2) — n/a: Precisely annotates the two Weixin MD5 dedup/upload sites, with the maintainer-bot keep_open verdict confirming the exact current-main substitutions against 614dc19.
• fix: add usedforsecurity=False to hashlib.sha1 in tui_gateway/server.py #72370 related — (+1/-1) — n/a: Annotates the TUI MCP revision SHA-1 constructor; its keep_open review corrects the symptom from a crash to loss of revision-based reload gating and requires a real-helper regression.
• fix: add usedforsecurity=False to hashlib.sha1 in tui_gateway/server (FIPS crash) #73278 [closed] related — (+1/-1) — n/a: Closed duplicate of fix: add usedforsecurity=False to hashlib.sha1 in tui_gateway/server.py #72370 with the identical MCP revision-hash change; contributor review closed it for missing regression coverage and corrected the claimed crash path.
• fix: add usedforsecurity=False to hashlib.md5 in context_compressor (#FIPS) #74632 related — (+1/-1) — n/a: Annotates the current compressor deduplication MD5 site reached by normal compression and proactive pruning; its keep_open review and contributor comments require a focused duplicate-output regression with a rejecting MD5 stub.

Duplicates

#52967 is the closed v2 duplicate/superset of #52783; #73278 is the closed identical duplicate of #72370. #39049 and #43937 overlap #54617 but target the retired path; #48472 is the Skills Hub subset of #62654, #56715 is a focused subset of #52783, and #66857 overlaps the Weixin slice of #56719/#65434.

Suggested consolidation

Author action on #65570: split out only non-security hash sites whose restricted-runtime failure is demonstrated, remove Feishu signature-verification, PKCE, and other security-context SHA-256 annotations, then add targeted constructor regressions. The visible keep_open reviews support salvage rather than current-form acceptance: retain focused current-path work such as #54617, #62654, #66857, #72370, and #74632 long enough to add the requested tests, consolidate overlapping slices into the smallest tested PRs, and close the remaining open subsets as explicit duplicates only after their unique sites have been carried forward.

Cross-PR triage: Reviewed 21 pull requests and 0 issues in this complex. Diffs were read for 20 of 21 PRs (rest unavailable); Assessment working set: 112 kB of PR diffs, 28 kB of issue/PR text, 22 kB of discussion (31 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.