fix: add usedforsecurity=False to hashlib.sha256/sha1 calls for FIPS - #51973
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
fix: add usedforsecurity=False to hashlib.sha256/sha1 calls for FIPS#51973AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Follow-up to the md5 fix (NousResearch#51962). hashlib.sha256() and hashlib.sha1() without usedforsecurity=False also fail on FIPS-enabled systems. All 48 call-sites across 39 files use SHA for non-security purposes (cache keys, content hashing, deduplication, checksums). Files: agent/ (6), gateway/ (7), hermes_cli/ (6), plugins/ (12), tools/ (5), run_agent.py, and other modules.
alt-glitch
added
type/security
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #51962 (md5 fix).
hashlib.sha256()andhashlib.sha1()withoutusedforsecurity=Falsealso fail on FIPS-enabled systems (RHEL 8/9 FIPS mode, government/enterprise Linux, hardened Docker images).All 48 call-sites across 39 files use SHA for non-security purposes (cache keys, content hashing, deduplication, checksums).
Error on FIPS systems
Changes (39 files, 48 replacements)
agent/gateway/hermes_cli/plugins/tools/Testing
ast.parse()usedforsecurityparameter available since Python 3.9 (project requires >=3.11)