fix(desktop): keep generated images out of tool overflow - #65142
Merged
Conversation
Generalize the clarify opt-out into an UNBOUNDABLE_TOOLS set so a run containing image_generate also stays a plain, fully-visible stack instead of collapsing into the bounded window, where the max-height + gradient mask clipped the image the same way it clipped clarify forms.
OutThisLife
enabled auto-merge
July 15, 2026 18:09
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…tool-overflow fix(desktop): keep generated images out of tool overflow
3 tasks
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…tool-overflow fix(desktop): keep generated images out of tool overflow
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…tool-overflow fix(desktop): keep generated images out of tool overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNBOUNDABLE_TOOLSset (clarify,image_generate). A run containing any of them stays a plain, fully-visible stack instead of collapsing into the fixed-height auto-scrolling window, where themax-height+ gradient mask hid the image.Test plan
npx vitest run --project ui src/components/assistant-ui/tool/fallback.test.tsnpx eslint src/components/assistant-ui/tool/fallback.tsx src/components/assistant-ui/tool/fallback.test.tsnpm run typecheck— fails locally on a pre-existing@assistant-ui/reactversion mismatch in the local install (same failures on cleanmain, in files this PR doesn't touch); green in CI.