Skip to content

fix(desktop): keep generated images out of tool overflow - #65142

Merged
OutThisLife merged 1 commit into
mainfrom
bb/fix-image-tool-overflow
Jul 15, 2026
Merged

fix(desktop): keep generated images out of tool overflow#65142
OutThisLife merged 1 commit into
mainfrom
bb/fix-image-tool-overflow

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to the clarify overflow fix (fix(desktop): keep clarify prompts out of tool overflow #64679): the same bounded tool-call window was clipping generated images.
  • Generalizes the one-off clarify opt-out into an UNBOUNDABLE_TOOLS set (clarify, image_generate). A run containing any of them stays a plain, fully-visible stack instead of collapsing into the fixed-height auto-scrolling window, where the max-height + gradient mask hid the image.
  • Ordinary 3+ tool runs still collapse exactly as before.

Test plan

  • npx vitest run --project ui src/components/assistant-ui/tool/fallback.test.ts
  • npx eslint src/components/assistant-ui/tool/fallback.tsx src/components/assistant-ui/tool/fallback.test.ts
  • npm run typecheck — fails locally on a pre-existing @assistant-ui/react version mismatch in the local install (same failures on clean main, in files this PR doesn't touch); green in CI.

Generalize the clarify opt-out into an UNBOUNDABLE_TOOLS set so a run
containing image_generate also stays a plain, fully-visible stack instead
of collapsing into the bounded window, where the max-height + gradient mask
clipped the image the same way it clipped clarify forms.
@OutThisLife
OutThisLife enabled auto-merge July 15, 2026 18:09
@OutThisLife
OutThisLife merged commit 91f8713 into main Jul 15, 2026
21 checks passed
@OutThisLife
OutThisLife deleted the bb/fix-image-tool-overflow branch July 15, 2026 18:13
@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 15, 2026
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…tool-overflow

fix(desktop): keep generated images out of tool overflow
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…tool-overflow

fix(desktop): keep generated images out of tool overflow
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
…tool-overflow

fix(desktop): keep generated images out of tool overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants