Skip to content

fix(desktop): keep clarify prompts out of tool overflow - #64679

Merged
OutThisLife merged 1 commit into
mainfrom
bb/fix-clarify-tool-overflow
Jul 15, 2026
Merged

fix(desktop): keep clarify prompts out of tool overflow#64679
OutThisLife merged 1 commit into
mainfrom
bb/fix-clarify-tool-overflow

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Summary

  • treat clarify as a hard boundary for bounded adjacent tool-call runs
  • keep clarify and multi-choice forms fully visible while preserving overflow behavior for ordinary tool runs
  • cover both bounded ordinary runs and clarify opt-out behavior

Test plan

  • npx vitest run --project ui src/components/assistant-ui/tool/fallback.test.ts src/components/assistant-ui/clarify-tool.test.tsx
  • npx eslint src/components/assistant-ui/tool/fallback.tsx src/components/assistant-ui/tool/fallback.test.ts
  • npm run typecheck

Treat clarify as a hard boundary for bounded tool runs so interactive forms remain fully visible and usable.
@OutThisLife
OutThisLife enabled auto-merge July 15, 2026 01:03
@OutThisLife
OutThisLife merged commit 6997dc8 into main Jul 15, 2026
21 checks passed
@OutThisLife
OutThisLife deleted the bb/fix-clarify-tool-overflow branch July 15, 2026 01:06
@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 15, 2026
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…y-tool-overflow

fix(desktop): keep clarify prompts out of tool overflow
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…y-tool-overflow

fix(desktop): keep clarify prompts out of tool overflow
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
…y-tool-overflow

fix(desktop): keep clarify prompts out of tool overflow
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…y-tool-overflow

fix(desktop): keep clarify prompts out of tool overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants