Skip to content

fix(runtime): preserve resolved metadata in agent forks - #62081

Merged
kshitijk4poor merged 1 commit into
NousResearch:mainfrom
kshitijk4poor:salvage/61567-curator-runtime
Jul 10, 2026
Merged

kshitijk4poor merged 1 commit into
NousResearch:mainfrom
kshitijk4poor:salvage/61567-curator-runtime

Conversation

@kshitijk4poor

Copy link
Copy Markdown

Summary

Curator and auxiliary agent forks now retain the complete resolved runtime bundle, including credential rotation, task request overrides, effective model/output limits, and ACP transport metadata.

Changes

  • Preserve @infinitycrew39's curator credential-pool and request-override forwarding commits.
  • Curator: honor resolved effective model, output cap, ACP transport, and auxiliary.curator.extra_body with task-local precedence.
  • Background review: use the routed runtime's pool/overrides/model/cap/ACP metadata instead of the parent provider's pool.
  • Delegation: forward resolved request overrides and output caps while retaining existing endpoint-aware pool resolution.
  • Add regression coverage for curator, background-review, and delegated runtime handoff.

Validation

  • 235 targeted tests passed on the final branch.
  • Real isolated custom-provider E2E forced a stale-key 401, rotated to the valid pool credential, and preserved request metadata.
  • Load-bearing negative controls failed at the expected parent boundaries.
  • Ruff, py_compile, Windows-footgun scan, ty baseline comparison, and git diff --check passed.
  • Final adversarial Codex review: clean.

Credit

Salvages #61567 by @infinitycrew39. Both contributor commits retain original authorship, followed by a separate maintainer widening commit.

Closes #61567

@kshitijk4poor
kshitijk4poor enabled auto-merge (rebase) July 10, 2026 13:03
auto-merge was automatically disabled July 10, 2026 13:08

Rebase failed

@alt-glitch alt-glitch added type/bug Something isn't working comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint tool/delegate Subagent delegation area/auth Authentication, OAuth, credential pools P2 Medium — degraded but workaround exists labels Jul 10, 2026
@alt-glitch

Copy link
Copy Markdown

This was generated by AI during triage.

Related: salvages #61567 (closed) and extends the just-merged #62077 (curator + background-review routing) to the delegation path (tools/delegate_tool.py: request-override + max_tokens forwarding, net-new vs #62077). Not a duplicate -- superset with net-new delegation content. Maintainer should decide whether to land the delegation extension on top of #62077.

@kshitijk4poor
kshitijk4poor force-pushed the salvage/61567-curator-runtime branch from d56874a to aa44b3b Compare July 10, 2026 13:15
@kshitijk4poor
kshitijk4poor enabled auto-merge (rebase) July 10, 2026 13:15
@kshitijk4poor
kshitijk4poor merged commit 8727e67 into NousResearch:main Jul 10, 2026
29 checks passed
@kshitijk4poor
kshitijk4poor deleted the salvage/61567-curator-runtime branch August 5, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists tool/delegate Subagent delegation type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants