fix(curator): forward credential pool from runtime resolution - #61567
Closed
infinitycrew39 wants to merge 2 commits into
Closed
infinitycrew39 wants to merge 2 commits into
infinitycrew39 wants to merge 2 commits into
Conversation
Curator review forks now pass credential_pool and request_overrides from resolve_runtime_provider into AIAgent so pool-backed custom providers can rotate credentials on 401 like main chat.
Regression test that _run_llm_review passes credential_pool and request_overrides from resolve_runtime_provider into the curator AIAgent fork.
alt-glitch
added
type/bug
|
Merged via #62077. Your two commits were cherry-picked and rebase-merged with authorship preserved; the follow-up completed effective-model/output-cap/ACP handoff, wired |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credential_poolandrequest_overridesfromresolve_runtime_provider()into the curator reviewAIAgentfork.hermes curator runfailing with HTTP 401 on pool-backed named custom providers (e.g.custom:hyper-charm) while main chat could rotate pool credentials or fall back.Root cause
Curator resolved runtime credentials correctly but only forwarded
api_key/base_url/api_mode. Without the live pool handle, the fork could not rotate on auth errors and got stuck on the first stale key.Test plan
tests/agent/test_curator.py::test_review_fork_forwards_runtime_pool_and_overridescustom:hyper-charm+hermes authpool +hermes curator run