fix(model): discover no-key custom provider catalogs - #61928
Merged
kshitijk4poor merged 4 commits intoJul 10, 2026
Merged
Conversation
alt-glitch
added
type/bug
This was referenced Jul 10, 2026
10 tasks
teknium1
pushed a commit
that referenced
this pull request
Jul 27, 2026
…gular default_model doesn't suppress live discovery A providers: entry with only a default_model/model (no explicit models: list) is un-narrowed — the singular field is just the active selection. Section 3 derived has_explicit_models from the merged models list, so the lone default_model entry counted as an explicit catalog and suppressed the /v1/models probe for no-key endpoints, leaving a one-line /model picker menu for local llama.cpp/Ollama/vLLM servers. Track explicit models: declarations separately at group-build time (mirrors section 4's declaration-tracking from #40542 / PR #61928) and gate the probe on that instead. Salvaged from PR #68984 by @vigilancetech-com (the probe_custom_providers gate removal in that PR is not taken — the GUI no-probe gate is intentional).
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…gular default_model doesn't suppress live discovery A providers: entry with only a default_model/model (no explicit models: list) is un-narrowed — the singular field is just the active selection. Section 3 derived has_explicit_models from the merged models list, so the lone default_model entry counted as an explicit catalog and suppressed the /v1/models probe for no-key endpoints, leaving a one-line /model picker menu for local llama.cpp/Ollama/vLLM servers. Track explicit models: declarations separately at group-build time (mirrors section 4's declaration-tracking from NousResearch#40542 / PR NousResearch#61928) and gate the probe on that instead. Salvaged from PR NousResearch#68984 by @vigilancetech-com (the probe_custom_providers gate removal in that PR is not taken — the GUI no-probe gate is intentional).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No-key custom providers with only an active
model:now discover their live catalog, while explicitmodels:catalogs remain authoritative.Changes
main.discover_models: falsebehavior.Validation
git diff --checkpassed.Credit
Closes #40542.