fix(model): probe no-key custom provider catalogs - #55158
Closed
ooiuuii wants to merge 1 commit into
Closed
Conversation
ooiuuii
force-pushed
the
fix/custom-provider-no-key-probe
branch
from
July 6, 2026 02:06
c0ae8c8 to
b8fb31c
Compare
Collaborator
|
Merged via #61928. Your focused implementation was cherry-picked and rebase-merged with authorship preserved; follow-up commits fixed declaration-before-dedup and strengthened probe-policy isolation. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
custom_providers:model picker discovery for no-key local/OpenAI-compatible endpoints.The Section 4 picker grouping already documents that singular
model:is only the active model, whilemodels:is the explicit configured catalog. The probe gate still used the combinedgrp['models']list, so a no-key local provider with onlymodel:skipped/v1/modelsdiscovery and/modelshowed only one active model.This tracks whether a grouped custom provider actually has an explicit
models:catalog and only suppresses no-key live discovery for that explicit list. Singularmodel:no longer blocks live discovery.Fixes #40542.
Related Issue
Fixes #40542
Type of Change
Changes Made
hermes_cli/model_switch.pyhas_explicit_modelsflag to Section 4 custom-provider groups.models:dict/list entries, not singularmodel:.tests/hermes_cli/test_model_switch_custom_providers.pyfetch_api_modelsstub.custom_providerswith only singularmodel:still probe/v1/modelsand use the live catalog.How to Test
Run:
Validation
tests/hermes_cli/test_model_switch_custom_providers.py— 29 passedtests/hermes_cli/test_user_providers_model_switch.py— 35 passedruff check hermes_cli/model_switch.py tests/hermes_cli/test_model_switch_custom_providers.py— passgit diff --check— passpython scripts/check-windows-footguns.py --diff origin/main— passAutoreview note: no repository-local autoreview helper was present in this checkout.