Refactor electron headers handling in desktop.nix - #61824
Conversation
…op.nix Remove hardcoded hash and use electron.headers directly instead. Fixes NousResearch#61443
Competing fixes for #61443: this PR derives the Electron node-headers from the |
|
Prior art: #53202 (opened 2026-06-26) makes the same change in #53202 also adds an offline Flagging so a maintainer evaluating this vs #61530 sees all three options: #53202 = this same durable derive + the CI guard that prevents recurrence. |
What does this PR do?
Remove hardcoded hash and use
electron.headersfromnixpkgsinput directly instead.This improves maintainability of the nix build, as the hash does not need to be changed when nixpkgs is updated.
Additionally, it can also be used with different nixpkgs versions (e.g. by using
nix run github:NousResearch/hermes-agent --override-input nixpkgs nixpkgs).Related Issue
Fixes #61443
Type of Change
Changes Made
How to Test
To reproduce, build the desktop variant using nix, by doing:
nix build github:NousResearch/hermes-agent#desktopAfter this PR, you can also use it with (somewhat) different nixpkgs versions with a different electron. For example do the following:
nix build github:NousResearch/hermes-agent#desktop --override-input nixpkgs github:NixOS/nixpkgs/a0374025a863d007d98e3297f6aa46cc3141c2f0This fails in main, but succeeds after this PR, as we use a slightly different electron version.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs