fix(desktop): bump electron node-headers sha256 to match pinned electron.version - #61530
jackjin1997 wants to merge 1 commit into
Conversation
…ron.version electronHeaders fetches from a URL templated off electron.version, but the sha256 was hardcoded to a prior electron release. nixpkgs-nixos-unstable now resolves electron to 41.9.1, so the fixed-output derivation hash-mismatches and `nix build .#desktop` fails. Fixes NousResearch#61443
Related: fixes #61443 ( |
|
Thanks for the focused fix. Current main still derives the Electron-header URL from The related durable alternative, #61824, is still open, so it does not supersede this immediate repair on main. Automated hermes-sweeper review. |
|
Related: #53202 (2026-06-26) fixes the same break durably — it replaces the hand-pinned |
|
Thanks for flagging this — #53202 has since been expanded to replace the hand-pinned fetchurl with nixpkgs' electron.headers (version-locked, no hash to bump on future electron bumps) plus an offline nix-build CI guard covering .#desktop, and #61824 is also refactoring this same spot. My hash bump is a strictly narrower stopgap than either — closing in favor of #53202's durable fix. |
What does this PR do?
electronHeadersinnix/desktop.nixfetches from a URL templated offelectron.version, but itssha256was hardcoded to a prior electron release.nixpkgs-nixos-unstablenow resolveselectronto41.9.1, so the URL and the pinned hash have desynced and the fixed-output derivation fails with a hash mismatch —nix build .#desktopis broken.This only surfaces at Nix build time; the networked Docker /
npm cipaths are unaffected, which is why it merged green in the first place. The reported hash mismatch error includes the actual sha256 Nix computed for the 41.9.1 tarball (got:line), so this bump uses that first-party value rather than a guess.Related Issue
Fixes #61443
Type of Change
Changes Made
nix/desktop.nix: bumpelectronHeaders.sha256from the stale pinned-electron-version hash to the hash Nix reported for the currentelectron.version(41.9.1), with a comment noting it needs to move in lockstep withelectron.versiongoing forward.How to Test
nix build .#desktopon currentmainfails with:sha256value, the fixed-output derivation matches and the build proceeds past theelectronHeadersfetch.I don't have a local Nix toolchain in this environment to run
nix build .#desktopmyself, so I can't attach a green build log — the fix is the exactgot:value from the issue's own Nix error trace, not a derived/guessed one. Flagging this so a maintainer or reviewer with Nix available can do the final confirm; happy to iterate if the value needs adjusting for a different platform's tarball.Checklist
Code
pytest tests/ -qand all tests pass — N/A, this is a Nix-only data value change with no Python test surface, and I don't have a local Nix toolchain to runnix buildin this environment (see note above).#desktop, which is what will catch this class going forwardgit show origin/main:nix/desktop.nixthat the current hash/URL mismatch matches the issue description exactly; did not runnix build(no local Nix)Documentation & Housekeeping
AI Disclosure
This bug was identified and fixed with AI assistance.