fix(cli): get_disabled_skills handles null and scalar skills config (#13026) - #61797
Merged
Conversation
skills: null crashed with AttributeError, and a bare scalar disabled: my-skill was split into a set of characters. Both now normalize the same way agent.skill_utils._normalize_string_set does: null -> empty set, scalar -> single-item set. Non-dict skills sections are ignored. Closes #13026.
alt-glitch
added
type/bug
This was referenced Jul 10, 2026
This was referenced Jul 12, 2026
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ousResearch#61797) skills: null crashed with AttributeError, and a bare scalar disabled: my-skill was split into a set of characters. Both now normalize the same way agent.skill_utils._normalize_string_set does: null -> empty set, scalar -> single-item set. Non-dict skills sections are ignored. Closes NousResearch#13026.
justemu
pushed a commit
to justemu/hermes-agent
that referenced
this pull request
Jul 18, 2026
…ousResearch#61797) skills: null crashed with AttributeError, and a bare scalar disabled: my-skill was split into a set of characters. Both now normalize the same way agent.skill_utils._normalize_string_set does: null -> empty set, scalar -> single-item set. Non-dict skills sections are ignored. Closes NousResearch#13026.
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ousResearch#61797) skills: null crashed with AttributeError, and a bare scalar disabled: my-skill was split into a set of characters. Both now normalize the same way agent.skill_utils._normalize_string_set does: null -> empty set, scalar -> single-item set. Non-dict skills sections are ignored. Closes NousResearch#13026.
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ousResearch#61797) skills: null crashed with AttributeError, and a bare scalar disabled: my-skill was split into a set of characters. Both now normalize the same way agent.skill_utils._normalize_string_set does: null -> empty set, scalar -> single-item set. Non-dict skills sections are ignored. Closes NousResearch#13026.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…ousResearch#61797) skills: null crashed with AttributeError, and a bare scalar disabled: my-skill was split into a set of characters. Both now normalize the same way agent.skill_utils._normalize_string_set does: null -> empty set, scalar -> single-item set. Non-dict skills sections are ignored. Closes NousResearch#13026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_disabled_skills()inhermes_cli/skills_config.pynow normalizes malformed config values instead of crashing or misbehaving:skills: nullno longer raisesAttributeError, and a bare scalardisabled: my-skillis treated as one skill name instead of being split into a set of its characters.Closes #13026 (both reported defects reproduced live on current main before the fix).
Changes
hermes_cli/skills_config.py: new_normalize_skill_names()mirroringagent.skill_utils._normalize_string_set(null → empty, scalar → single-item, list → stripped names); non-dictskillssections ignored; applied to both the global and platform-disabled pathstests/hermes_cli/test_skills_config.py: 5 new tests (null section, null key, scalar split, scalar platform list, non-dict section)Validation
{"skills": None}set()disabled: my-skill{'m','y','-','s','k','i','l'}{'my-skill'}platform_disabled.telegram: tg-skill{'tg-skill'}union globalThe agent-side reader (
agent/skill_utils.py) already normalized correctly; this brings the CLI/web-server read path (hermes skills, dashboard skill toggles) into agreement.Infographic