fix(cli): normalize disabled skills config parsing - #13047
Conversation
兼容 skills:null 与字符串 disabled 配置,避免字符拆分与空对象崩溃,并补充回归测试覆盖。
|
Great work on this fix! 🎉 This PR properly normalizes the disabled skills config parsing with platform-specific fallback logic. The changes look solid: ✅ Key improvements:
✅ Test coverage highlights:
The normalization logic ensures consistent behavior across CLI, gateway, and platform-specific contexts. This unblocks proper skill management per-platform while maintaining backward compatibility. Ready to merge! 🚀 |
|
Salvaged onto current |
Duplicate of #13078 — same |
|
Thanks for the report and regression tests. This is already implemented on current
|
Summary
get_disabled_skills()对异常配置结构的健壮性:skills: null不再崩溃。skills.disabled为字符串时被拆成字符集合的问题,统一按单个技能名处理。Test plan
python -m pytest tests/hermes_cli/test_skills_config.py -q -n 4Closes #13026