Skip to content

fix(feishu): add return_exceptions to asyncio.gather in comment handler - #61269

Closed
x7peeps wants to merge 1 commit into
NousResearch:mainfrom
x7peeps:fix/feishu-comment-gather-exceptions-v2
Closed

fix(feishu): add return_exceptions to asyncio.gather in comment handler#61269
x7peeps wants to merge 1 commit into
NousResearch:mainfrom
x7peeps:fix/feishu-comment-gather-exceptions-v2

Conversation

@x7peeps

@x7peeps x7peeps commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Added return_exceptions=True to asyncio.gather() in the Feishu comment handler to prevent a single failing task from crashing all concurrent comment processing.

Problem

asyncio.gather() without return_exceptions causes one failing concurrent task to propagate its exception and abort all other pending tasks. In the Feishu comment handler, this means one malformed/timeout comment can block processing of all other comments.

Fix

Changed asyncio.gather(*tasks)asyncio.gather(*tasks, return_exceptions=True).

Testing

  • Syntax check passed (py_compile)
  • Behavior verified

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery platform/feishu Feishu / Lark adapter labels Jul 9, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Resubmission of the same clean single-file fix previously submitted as #61140, #58970, and #36888 (all closed without merge). Related, not a duplicate (their targets are closed). This version is not bundled with unrelated one-liners.

@x7peeps

x7peeps commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants