fix(feishu): add return_exceptions to asyncio.gather in comment handler - #61269
Closed
x7peeps wants to merge 1 commit into
Closed
fix(feishu): add return_exceptions to asyncio.gather in comment handler#61269x7peeps wants to merge 1 commit into
x7peeps wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
Closing as duplicate |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
return_exceptions=Truetoasyncio.gather()in the Feishu comment handler to prevent a single failing task from crashing all concurrent comment processing.Problem
asyncio.gather()withoutreturn_exceptionscauses one failing concurrent task to propagate its exception and abort all other pending tasks. In the Feishu comment handler, this means one malformed/timeout comment can block processing of all other comments.Fix
Changed
asyncio.gather(*tasks)→asyncio.gather(*tasks, return_exceptions=True).Testing