fix(feishu): add return_exceptions to asyncio.gather in comment handler - #58970
Closed
x7peeps wants to merge 2 commits into
Closed
fix(feishu): add return_exceptions to asyncio.gather in comment handler#58970x7peeps wants to merge 2 commits into
x7peeps wants to merge 2 commits into
Conversation
Collaborator
Related: #36888 (the earlier, now-closed feishu return_exceptions fix). This PR re-does that feishu fix and additionally bundles an unrelated |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add to in the feishu comment handler so that a failure in one parallel fetch (doc meta or comment detail) does not crash the entire handler.
Problem
In , line 1205 calls without . If either or raises (e.g., network error, API rate limit), the gather propagates the exception immediately, cancelling the other task and failing the entire comment handling flow. The code then calls on both results, which would also crash on an exception value.
Fix
Testing