Skip to content

fix(dashboard): prevent SSO auto-redirect crash on password-only providers - #61155

Closed
gigakun3030 wants to merge 1 commit into
NousResearch:mainfrom
gigakun3030:fix/dashboard-auth-sso-redirect
Closed

gigakun3030 wants to merge 1 commit into
NousResearch:mainfrom
gigakun3030:fix/dashboard-auth-sso-redirect

Conversation

@gigakun3030

Copy link
Copy Markdown
Contributor

Prevent SSO auto-redirect flow from triggering on password-only authentication providers, which causes 500 errors. Filters out these providers in the SSO middleware check.

@alt-glitch alt-glitch added type/bug Something isn't working comp/dashboard Web dashboard / control panel UI (dashboard/, landing) area/auth Authentication, OAuth, credential pools duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists labels Jul 8, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.

Duplicate of #54887 — same code site (_auto_sso_response in hermes_cli/dashboard_auth/middleware.py) and same supports_password mechanism to skip auto-SSO for password-only providers. #54887 is the earliest-open canonical fix of this cluster (into which #57427/#58044/#60247/#58905 also dedup). This PR filters password-only providers before the length check rather than returning None after it — a minor variation of the same fix. Related anchor issue: #55130.

@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the focused dashboard-auth fix. This is an automated hermes-sweeper review; current main already provides the requested behavior, so this PR is superseded.

  • hermes_cli/dashboard_auth/middleware.py:190 returns None when the sole provider has supports_password=True, falling back to /login rather than auto-starting OAuth.
  • Commit 3e24b16f566045399012bc1185fe0cdb6e1a1be9 added that guard and is present in current main.
  • hermes_cli/dashboard_auth/routes.py:195-202 also redirects direct /auth/login?provider=<password-provider> requests to /login, covering the reported 500 route.
  • This matches the prior duplicate triage on fix(dashboard-auth): skip auto-SSO redirect for password-only providers #54887, whose discussion records the same guard and its superseding merged work.

@teknium1 teknium1 closed this Jul 10, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/dashboard Web dashboard / control panel UI (dashboard/, landing) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants